-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MANA: add driver survey test #2980
Conversation
mana_en drivers should be present in kernels >= 5.15. mana_ib drivers should be present in kernels >= 6.2. Add a test to survey images and check for mana drivers in images.
d86f226
to
1778d01
Compare
microsoft/testsuites/core/mana.py
Outdated
kconfig = node.tools[KernelConfig] | ||
|
||
# Check kconfig for mana | ||
mana_is_builtin = kconfig.is_built_in(mana_driver_name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can add a new method for the common code used by these two cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
combined, thanks!
) | ||
class ManaDriverCheck(TestSuite): | ||
MANA_DRIVER_MESSAGE_PATTERN = re.compile(r"\[\s*[0-9.]+\s*\]\s+mana\s+.*") | ||
MANA_IB_DRIVER_MESSAGE_PATTERN = re.compile(r"\[\s*[0-9.]+\s*\]\s+mana_ib\s+.*") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add the sample messages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the updated with sample messages
mana_driver_name = "mana" | ||
dmesg = node.tools[Dmesg] | ||
modprobe = node.tools[Modprobe] | ||
kconfig = node.tools[KernelConfig] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can check config even there is no mana devices
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a test just kconfig only
block merge on testing after refactor... |
645a53f
to
e4866c6
Compare
mana_en drivers should be present in kernels >= 5.15.
mana_ib drivers should be present in kernels >= 6.2.
Add a test to survey images and check for mana drivers in images.
Test checks kernel config and modprobe to verify the driver is present as either a builtin or module. It checks kernel logs to verify the driver had loaded as expected.