Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpinning xgboost version #745

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Unpinning xgboost version #745

wants to merge 2 commits into from

Conversation

mshr-h
Copy link
Collaborator

@mshr-h mshr-h commented Dec 25, 2023

Fix #732
Seems like 1.12.0 has the fix?

@mshr-h mshr-h changed the title unpinning xgboost version Unpinning xgboost version Dec 25, 2023
@ksaur
Copy link
Collaborator

ksaur commented Jan 2, 2024

Thanks! It should, but we need to first fix #744. My goal is to patch by end of week!

@ksaur
Copy link
Collaborator

ksaur commented Jan 2, 2024

please rebase and hopefully it works! :)

@mshr-h mshr-h force-pushed the unpin-xgb branch 2 times, most recently from 1a66a9c to 58dadc2 Compare January 9, 2024 02:17
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (94ce98c) 90.25% compared to head (58dadc2) 90.25%.

❗ Current head 58dadc2 differs from pull request most recent head 27d2112. Consider uploading reports for the commit 27d2112 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #745   +/-   ##
=======================================
  Coverage   90.25%   90.25%           
=======================================
  Files          80       80           
  Lines        4677     4677           
  Branches      856      856           
=======================================
  Hits         4221     4221           
  Misses        259      259           
  Partials      197      197           
Flag Coverage Δ
unittests 90.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XGBoost 2.0.0 breaks tests
3 participants