-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added support for lightgbm booster #540
Conversation
@marsupialtail Thanks so much for the PR! :) I think there are some lint things to check on in the CI/CD. Can you please also add tests inside of test_lightgbm_converter.py to make sure that all lines of |
I added the tests based on the LGBRanker PR you referred. Not sure if that's what you are looking for. |
@marsupialtail I think there is another lint thing. (I tried to give permissions so the CI/CD would automatically run for you but it didn't seem to work.) PR looks great otherwise! (cc: @interesaaat any comments? ) |
Ok I think I fixed it so you should be able to run the ci/cd without additional permissions. (Github must have changed some setting, because the subsequent run should have 'just ran') There's some formatting issue, please take a look. Thanks! |
Sorry but I absolutely hate lint. Not sure if I will have too much motivation to finish fixing the lint problems :-( |
Codecov Report
@@ Coverage Diff @@
## main #540 +/- ##
==========================================
+ Coverage 90.62% 90.63% +0.01%
==========================================
Files 78 78
Lines 4510 4516 +6
Branches 839 839
==========================================
+ Hits 4087 4093 +6
Misses 237 237
Partials 186 186
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Thanks for the contribution and for sticking with it @marsupialtail ! |
Issue #539 : added support for LightGBM booster