Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Enable submitting jobs to compute instances #902

Merged
merged 5 commits into from
Jul 19, 2023
Merged

BUG: Enable submitting jobs to compute instances #902

merged 5 commits into from
Jul 19, 2023

Conversation

ant0nsc
Copy link
Collaborator

@ant0nsc ant0nsc commented Jul 18, 2023 •
edited
Loading

This PR removes the check for available number of nodes, meaning the code will run just fine on any type of compute.
Closes #901

@codecov
Copy link

codecov bot commented Jul 18, 2023 •
edited
Loading

Codecov Report

Merging #902 (e02c276) into main (8575478) will decrease coverage by 12.14%.
The diff coverage is 25.00%.

Impacted file tree graph

Flag Coverage Δ
hi-ml 83.29% <ø> (ø)
hi-ml-azure 27.04% <25.00%> (+0.09%) ⬆️
hi-ml-cpath 48.92% <ø> (-27.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hi-ml-azure/src/health_azure/himl.py 41.93% <25.00%> (+0.72%) ⬆️

... and 56 files with indirect coverage changes

kenza-bouzid
kenza-bouzid approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@kenza-bouzid kenza-bouzid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

hi-ml-azure/testazure/testazure/test_himl.py Outdated Show resolved Hide resolved
Shruthi42
Shruthi42 approved these changes Jul 19, 2023
View reviewed changes
hi-ml-cpath/requirements_run.txt Show resolved Hide resolved
fepegar
fepegar approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@fepegar fepegar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. My only suggestion would be to replace "cluster" with "target" pretty much everywhere.

@ant0nsc ant0nsc merged commit 036e231 into main Jul 19, 2023
48 of 50 checks passed
@ant0nsc ant0nsc deleted the antonsc/num_nodes branch July 19, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fepegar fepegar fepegar approved these changes

@Shruthi42 Shruthi42 Shruthi42 approved these changes

@kenza-bouzid kenza-bouzid kenza-bouzid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Submitting a job to a compute instance fails because the number of nodes can't be read
4 participants
@ant0nsc @fepegar @Shruthi42 @kenza-bouzid