Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix KeyError when converting svs to tiff #891

Merged
merged 1 commit into from
May 30, 2023
Merged

Conversation

kenza-bouzid
Copy link
Contributor

svs has different metadata properties than Tiff and NDPI. This fix handles the case when get_mpp from monai fails with a KeyError exception missing "Tiff.XResolution" and "Tiff.YResolution"

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #891 (ad557a1) into main (e8f6b44) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

Impacted file tree graph

Flag Coverage Δ
hi-ml-cpath 76.04% <50.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/health_cpath/preprocessing/tiff_conversion.py 87.50% <50.00%> (-1.50%) ⬇️

@kenza-bouzid kenza-bouzid merged commit 3f0ae71 into main May 30, 2023
@kenza-bouzid kenza-bouzid deleted the kenzab/fix_mpp branch May 30, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants