BUG: Fix for duplicate authentication #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more.
|
![github-advanced-security[bot]](https://github.com/avatars/in/57789?s=60&v=4){kind=small}
| raise ValueError(f"Couldn't connect to MLClient: {e}") | ||
| logging.info(f"Logged into AzureML workspace {ml_client.workspace_name}") | ||
| return ml_client | ||
| logger.info(f"Using MLClient for AzureML workspace {workspace_name} as specified by environment variables") |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
fepegar
reviewed
May 9, 2023
|
Can you please summarise the changes in this PR so it's a bit easier to review? |
kenza-bouzid
approved these changes
May 9, 2023
for more information, see https://pre-commit.ci
…/hi-ml into antonsc/duplicate_auth
|
I will take a look at this tomorrow. |
fepegar
reviewed
May 12, 2023
fepegar
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve issues with AML SDK v1/v2: Even in the v2 code path we are creating v1 workspaces, leading to duplicate authentication requests.
To achieve that, a couple of other changes were necessary:
Also added more detailed logging for dataset creation, and a commandline flag to control logging level.