-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor pod config generation in tests #1180
Merged
anmaxvl
merged 3 commits into
microsoft:master
from
anmaxvl:tests/pod-sandbox-config-options
Sep 29, 2021
Merged
Refactor pod config generation in tests #1180
anmaxvl
merged 3 commits into
microsoft:master
from
anmaxvl:tests/pod-sandbox-config-options
Sep 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add SandboxConfigOpt func type, which enables pluggable configuration of PodSandboxConfig. Signed-off-by: Maksim An <maksiman@microsoft.com>
anmaxvl
force-pushed
the
tests/pod-sandbox-config-options
branch
from
September 28, 2021 05:36
d39849b
to
658e7e4
Compare
dcantah
reviewed
Sep 28, 2021
This is sweet! I'll give another check later on |
Signed-off-by: Maksim An <maksiman@microsoft.com>
dcantah
approved these changes
Sep 28, 2021
@ambarve , @katiewasnothere PTAL |
Signed-off-by: Maksim An <maksiman@microsoft.com>
katiewasnothere
approved these changes
Sep 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
anmaxvl
added a commit
to anmaxvl/hcsshim
that referenced
this pull request
Sep 29, 2021
Lack of rebase when merging microsoft#1180 resulted in some test files being out of date and containing old helper function name Signed-off-by: Maksim An <maksiman@microsoft.com>
anmaxvl
added a commit
that referenced
this pull request
Sep 29, 2021
Lack of rebase when merging #1180 resulted in some test files being out of date and containing old helper function name Signed-off-by: Maksim An <maksiman@microsoft.com>
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Nov 17, 2021
Related work items: microsoft#1067, microsoft#1097, microsoft#1119, microsoft#1170, microsoft#1176, microsoft#1180, microsoft#1181, microsoft#1182, microsoft#1183, microsoft#1184, microsoft#1185, microsoft#1186, microsoft#1187, microsoft#1188, microsoft#1189, microsoft#1191, microsoft#1193, microsoft#1194, microsoft#1195, microsoft#1196, microsoft#1197, microsoft#1200, microsoft#1201, microsoft#1202, microsoft#1203, microsoft#1204, microsoft#1205, microsoft#1206, microsoft#1207, microsoft#1209, microsoft#1210, microsoft#1211, microsoft#1218, microsoft#1219, microsoft#1220, microsoft#1223
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SandboxConfigOpt func type, which enables pluggable configuration
of PodSandboxConfig.
Signed-off-by: Maksim An maksiman@microsoft.com