Skip to content

Commit

Permalink
Merge branch 'scalar-reconfigure'
Browse files Browse the repository at this point in the history
This allows fixing settings after a Scalar upgrade, or after botching
the enlistments configuration.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
  • Loading branch information
dscho committed May 14, 2024
2 parents 4cf3d95 + 015e51f commit 8646c53
Showing 1 changed file with 17 additions and 0 deletions.
17 changes: 17 additions & 0 deletions scalar.c
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,23 @@ static int set_recommended_config(int reconfigure)
int i;
char *value;

/*
* If a user has "core.usebuiltinfsmonitor" enabled, try to switch to
* the new (non-deprecated) setting (core.fsmonitor).
*/
if (!git_config_get_string("core.usebuiltinfsmonitor", &value)) {
char *dummy = NULL;
if (git_config_get_string("core.fsmonitor", &dummy) &&
git_config_set_gently("core.fsmonitor", value) < 0)
return error(_("could not configure %s=%s"),
"core.fsmonitor", value);
if (git_config_set_gently("core.usebuiltinfsmonitor", NULL) < 0)
return error(_("could not configure %s=%s"),
"core.useBuiltinFSMonitor", "NULL");
free(value);
free(dummy);
}

for (i = 0; config[i].key; i++) {
if (set_scalar_config(config + i, reconfigure))
return error(_("could not configure %s=%s"),
Expand Down

0 comments on commit 8646c53

Please sign in to comment.