Skip to content

Commit

Permalink
sparse-checkout: update files with a modify/delete conflict
Browse files Browse the repository at this point in the history
When using the sparse-checkout feature, the file might not be on disk
because the skip-worktree bit is on.

Signed-off-by: Kevin Willford <kewillf@microsoft.com>
  • Loading branch information
Kevin Willford authored and dscho committed Sep 18, 2024
1 parent a64248f commit 7a255d4
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 1 deletion.
2 changes: 1 addition & 1 deletion merge-recursive.c
Original file line number Diff line number Diff line change
Expand Up @@ -1593,7 +1593,7 @@ static int handle_change_delete(struct merge_options *opt,
* path. We could call update_file_flags() with update_cache=0
* and update_wd=0, but that's a no-op.
*/
if (change_branch != opt->branch1 || alt_path)
if (change_branch != opt->branch1 || alt_path || !file_exists(update_path))
ret = update_file(opt, 0, changed, update_path);
}
free(alt_path);
Expand Down
31 changes: 31 additions & 0 deletions t/t7615-merge-sparse-checkout.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
#!/bin/sh

test_description='merge can handle sparse-checkout'

. ./test-lib.sh

# merges with conflicts

test_expect_success 'setup' '
git branch -M main &&
test_commit a &&
test_commit file &&
git checkout -b delete-file &&
git rm file.t &&
test_tick &&
git commit -m "remove file" &&
git checkout main &&
test_commit modify file.t changed
'

test_expect_success 'merge conflict deleted file and modified' '
echo "/a.t" >.git/info/sparse-checkout &&
test_config core.sparsecheckout true &&
git checkout -f &&
test_path_is_missing file.t &&
test_must_fail git merge delete-file &&
test_path_is_file file.t &&
test "changed" = "$(cat file.t)"
'

test_done

0 comments on commit 7a255d4

Please sign in to comment.