This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
feat(Dropdown): highlight option by letter key #902
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silviuaavram
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #902 +/- ##
==========================================
- Coverage 80.57% 80.32% -0.26%
==========================================
Files 651 648 -3
Lines 8330 8366 +36
Branches 1420 1431 +11
==========================================
+ Hits 6712 6720 +8
- Misses 1603 1631 +28
Partials 15 15
Continue to review full report at Codecov.
|
silviuaavram
force-pushed
the
feat/letter-key-highlight
branch
from
4c69be4
to
bd858a6
Compare
silviuaavram
force-pushed
the
feat/letter-key-highlight
branch
from
ecf555e
to
bf75713
Compare
sophieH29
reviewed
Feb 21, 2019
| searchQuery: search ? '' : undefined, | ||
| value: multiple ? [] : null, | ||
| } | ||
| } | ||
|
|
||
| componentWillReceiveProps(newProps: DropdownProps) { |
There was a problem hiding this comment.
!!! componentWillReceiveProps is deprecated and will be removed in future versions
Consider using componentDidUpdate, see:
https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops
|
closing as it will be taken over by #1270 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only makes sense in non-search Dropdown.
Work in progress.
Postponed until some more important issues are fixed. Also needs some Downshift followups related to state updates, with highlightedIndex and isOpen.