Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

feat(Chat.Message): add 'author' and 'timestamp' props #41

Closed

Conversation

kuzhelov
Copy link
Contributor

@kuzhelov kuzhelov commented Aug 2, 2018

Chat.Message ('author' and 'timestamp') props

Basic layout, as well as key properties were introduced.

image

TODO

  • Conformance test
  • Minimal doc site example
  • Stardust base theme
  • Teams Light theme
  • Teams Dark theme
  • Teams Contrast theme
  • Confirm RTL usage
  • W3 accessibility check
  • Stardust accessibility check
  • Update glossary props table
  • Update the CHANGELOG.md

API Proposal

Content

image

<Chat.Message author="..." content="Sure thing! .." timestamp="..." />
<span class='ui-text'>Sure thing! ...</span>

Author

image

<Chat.Message author="Jane Doe" content="..." timestamp="..." />
<div class='ui-layout__main'>
  <h5 class='ui-header'>Jane Doe</h5>
  ..
</div>

Timestamp

image

<Chat.Message author="..." content="..." timestamp="Yesterday, 10:15 PM" />
<div class='ui-layout__end'>
  <span class='ui-text'>Jane Doe</span>
  ..
</div>

@codecov
Copy link

codecov bot commented Aug 2, 2018

Codecov Report

Merging #41 into master will increase coverage by 3.4%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #41     +/-   ##
=========================================
+ Coverage   82.94%   86.34%   +3.4%     
=========================================
  Files          59       59             
  Lines         850      857      +7     
  Branches      195      186      -9     
=========================================
+ Hits          705      740     +35     
+ Misses        141      113     -28     
  Partials        4        4
Impacted Files Coverage Δ
src/components/Text/Text.tsx 100% <ø> (+25%) ⬆️
src/components/Chat/ChatMessage.tsx 100% <100%> (ø) ⬆️
src/components/Layout/Layout.tsx 97.82% <0%> (+10.86%) ⬆️
src/components/Text/textRules.ts 100% <0%> (+100%) ⬆️
src/components/Text/textVariables.ts 100% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17229f1...c501e9b. Read the comment docs.

@kuzhelov kuzhelov changed the title [WIP] feat(Chat.Message): add 'author' and 'timestamp' props feat(Chat.Message): add 'author' and 'timestamp' props Aug 22, 2018
@kuzhelov
Copy link
Contributor Author

closing as this functionality will be introduced by #242.

@kuzhelov kuzhelov closed this Sep 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants