This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 55
fix(Chat): properly position actions
with overflow
#2363
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
dzearing,
ecraig12345,
JasonGore,
jdhuntington,
kenotron,
levithomason,
miroslavstastny and
mnajdova
as code owners
February 17, 2020 11:07
Perf comparison
Perf tests with no regressions
Generated by 🚫 dangerJS |
layershifter
commented
Feb 17, 2020
layershifter
commented
Feb 17, 2020
height: 0, | ||
} | ||
const messageRect: DOMRect = (positionActionMenu && | ||
_.invoke(messageNode, 'getBoundingClientRect')) || { height: 0 } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we paired with @miroslavstastny we realized that messageRect.height
is enough in this case
…/stardust-ui/react into fix/chat-overflow � Conflicts: � CHANGELOG.md � packages/react/src/components/Chat/ChatMessage.tsx
miroslavstastny
approved these changes
Feb 20, 2020
…/stardust-ui/react into fix/chat-overflow
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2298.