Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(Tooltip): Fix page crash when content is null #2332

Merged
merged 4 commits into from
Feb 11, 2020

Conversation

jurokapsiar
Copy link
Contributor

@jurokapsiar jurokapsiar commented Feb 9, 2020

Fix done by @dalprzemo - https://github.com/microsoft/fluent-ui-react/pull/2210/files

Need to merge it from internal branch as fork branches currently do not work with screener :(

All credit goes to @delprzemo, thanks a lot for the contribution and sorry for not meging your orignial PR...

Fixes #2196

@DustyTheBot
Copy link
Collaborator

DustyTheBot commented Feb 9, 2020

Warnings
⚠️ 1 perf regressions detected

Perf comparison

Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.55 0.45 1.22:1 2000 1102
🦄 Button.Fluent 0.13 0.2 0.65:1 1000 130
🔧 Checkbox.Fluent 0.89 0.31 2.87:1 1000 891
🔧 Dialog.Fluent 0.38 0.2 1.9:1 5000 1900
🔧 Dropdown.Fluent 3.88 0.42 9.24:1 1000 3876
🔧 Icon.Fluent 0.13 0.04 3.25:1 5000 673
🦄 Image.Fluent 0.05 0.09 0.56:1 5000 253
🔧 Slider.Fluent 1.62 0.35 4.63:1 1000 1622
🔧 Text.Fluent 0.06 0.02 3:1 5000 298
🦄 Tooltip.Fluent 0.2 19.77 0.01:1 5000 1020

🔧 Needs work     🎯 On target     🦄 Amazing

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio
Tooltip.Fluent 1020 2131 0.48:1
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TableMinimalPerf.default 732 632 1.16:1
Button.Fluent 130 116 1.12:1
StatusMinimalPerf.default 272 248 1.1:1
ItemLayoutMinimalPerf.default 2093 1921 1.09:1
ButtonSlotsPerf.default 717 663 1.08:1
HeaderMinimalPerf.default 514 476 1.08:1
AttachmentMinimalPerf.default 1158 1079 1.07:1
ChatWithPopoverPerf.default 690 645 1.07:1
IconMinimalPerf.default 338 315 1.07:1
ImageMinimalPerf.default 256 239 1.07:1
SliderMinimalPerf.default 1692 1603 1.06:1
TreeMinimalPerf.default 1069 1013 1.06:1
BoxMinimalPerf.default 265 252 1.05:1
DialogMinimalPerf.default 1924 1831 1.05:1
Text.Fluent 298 283 1.05:1
AlertMinimalPerf.default 657 632 1.04:1
CarouselMinimalPerf.default 2245 2154 1.04:1
TextAreaMinimalPerf.default 3446 3315 1.04:1
Checkbox.Fluent 891 859 1.04:1
RadioGroupMinimalPerf.default 455 443 1.03:1
Dialog.Fluent 1900 1844 1.03:1
Icon.Fluent 673 654 1.03:1
AvatarMinimalPerf.default 602 592 1.02:1
DropdownManyItemsPerf.default 474 465 1.02:1
FormMinimalPerf.default 881 862 1.02:1
ProviderMergeThemesPerf.default 1265 1235 1.02:1
ReactionMinimalPerf.default 2831 2774 1.02:1
Image.Fluent 253 249 1.02:1
Slider.Fluent 1622 1592 1.02:1
ChatDuplicateMessagesPerf.default 621 614 1.01:1
HierarchicalTreeMinimalPerf.default 894 885 1.01:1
InputMinimalPerf.default 1018 1004 1.01:1
LabelMinimalPerf.default 1009 995 1.01:1
PortalMinimalPerf.default 242 239 1.01:1
CustomToolbarPrototype.default 4368 4337 1.01:1
ToolbarMinimalPerf.default 846 839 1.01:1
AccordionMinimalPerf.default 220 220 1:1
ButtonMinimalPerf.default 133 133 1:1
ChatMinimalPerf.default 1868 1873 1:1
DividerMinimalPerf.default 1057 1058 1:1
ListCommonPerf.default 843 843 1:1
MenuButtonMinimalPerf.default 1648 1645 1:1
SplitButtonMinimalPerf.default 14132 14141 1:1
Avatar.Fluent 1102 1106 1:1
DropdownMinimalPerf.default 4056 4117 0.99:1
GridMinimalPerf.default 927 935 0.99:1
LoaderMinimalPerf.default 2734 2771 0.99:1
Dropdown.Fluent 3876 3935 0.99:1
ListMinimalPerf.default 302 308 0.98:1
ProviderMinimalPerf.default 642 658 0.98:1
SegmentMinimalPerf.default 1401 1438 0.97:1
AnimationMinimalPerf.default 501 521 0.96:1
CheckboxMinimalPerf.default 3946 4111 0.96:1
HeaderSlotsPerf.default 1500 1555 0.96:1
VideoMinimalPerf.default 782 817 0.96:1
FlexMinimalPerf.default 378 396 0.95:1
LayoutMinimalPerf.default 570 599 0.95:1
MenuMinimalPerf.default 2175 2298 0.95:1
PopupMinimalPerf.default 358 376 0.95:1
RefMinimalPerf.default 159 168 0.95:1
AttachmentSlotsPerf.default 4095 4380 0.93:1
EmbedMinimalPerf.default 7131 7779 0.92:1
TextMinimalPerf.default 290 360 0.81:1
TooltipMinimalPerf.default 1365 2453 0.56:1

Generated by 🚫 dangerJS

@jurokapsiar jurokapsiar changed the title [ignore] Screener test for remote https://github.com/microsoft/fluent-ui-react/pull/2210/files fix(Tooltip): Fix page crash when content is null Feb 11, 2020
@jurokapsiar jurokapsiar merged commit d7896d0 into master Feb 11, 2020
@jurokapsiar jurokapsiar deleted the tmp/test-screener-tooltip branch February 11, 2020 09:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ToolTip Bug
2 participants