This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Chat): positiong fixes for actions #2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
dzearing,
ecraig12345,
JasonGore,
jdhuntington,
kenotron,
levithomason,
miroslavstastny and
mnajdova
as code owners
Perf comparison
Generated by 🚫 dangerJS |
| builder => builder.hover(selectors.message).snapshot('Hovers the first message'), | ||
| builder => builder.click(selectors.message).snapshot('Focus the first message via mouse click'), | ||
| (builder, keys) => | ||
| builder.keys('body', keys.tab).snapshot('Focuses the first message via keyboard'), |
There was a problem hiding this comment.
nit: technically, this does not select the first message
There was a problem hiding this comment.
Good catch, renamed this step
layershifter
commented
Jan 31, 2020
packages/react/src/themes/teams/components/Attachment/attachmentStyles.ts
Outdated
Show resolved
Hide resolved
…stardust-ui/react into fix/chat-actions � Conflicts: � CHANGELOG.md
layershifter
commented
Jan 31, 2020
| */ | ||
| unstable_pinned && { flip: { enabled: false } }, | ||
| ), | ||
| [hasScrollableElement, position, offset, rtl, unstable_pinned, userModifiers], |
There was a problem hiding this comment.
We have userModifiers as dependency there as they are an object, to avoid recreation of Popper on each render I decided to use there deep memo strategy.
layershifter
commented
Jan 31, 2020
|
|
||
| return <Ref innerRef={contentRef}>{React.Children.only(child) as React.ReactElement}</Ref> | ||
| return <Ref innerRef={contentRef}>{React.Children.only(child)}</Ref> |
There was a problem hiding this comment.
Small type improvements there as in real world we allow to pass only React.ReactElement (forced via React.Children.only())
jurokapsiar
approved these changes
Jan 31, 2020
| const scrollParentElement = getScrollParent(contentRef.current) | ||
|
|
||
| return scrollParentElement !== scrollParentElement.ownerDocument.body | ||
| }, [contentRef]) |
There was a problem hiding this comment.
I don't think that using Ref as useMemo dependency works.
There was a problem hiding this comment.
As discussed in offline added a comment there.
miroslavstastny
approved these changes
Jan 31, 2020
miroslavstastny
pushed a commit
that referenced
this pull request
Feb 3, 2020
* fix(Chat): positiong fixes for actions * add changelog entry * update screener steps * revert change, add comment (cherry picked from commit b7980fc)
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2299.