This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(hooks): minor fixes to useAccessibility & useStyles #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
dzearing,
ecraig12345,
JasonGore,
jdhuntington,
kenotron,
levithomason,
miroslavstastny and
mnajdova
as code owners
Perf comparison
Generated by 🚫 dangerJS |
mnajdova
reviewed
Jan 24, 2020
| (_prevState: State, nextState: State) => forceUpdate(nextState), | ||
| [], | ||
| ) | ||
| const [, forceUpdate] = React.useReducer((c: number) => c + 1, 0) as [never, () => void] |
There was a problem hiding this comment.
Suggested change
| const [, forceUpdate] = React.useReducer((c: number) => c + 1, 0) as [never, () => void] | |
| const [, syncState] = React.useReducer((c: number) => c + 1, 0) as [never, () => void] |
Or just remove syncState and use forceUpdate
There was a problem hiding this comment.
We have only forceUpdate() now 👍
mnajdova
reviewed
Jan 24, 2020
| mergeProps(slotName, slotProps, latestDefinition.current), | ||
| [], | ||
| ) | ||
| return <SlotProps extends Record<string, any>>(slotName: string, slotProps: SlotProps) => |
mnajdova
approved these changes
Jan 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR performs two changes.
useAccessibility()- we found out based on usage (chore(Box|Button|Image|Avatar): converting components with hooks #2238) that there is no reasons to keep the same reference to returnedgetA11Propsfunction - there is no reasons to use it as a dependency in other hooks (React.useMemo(() => {}, [getA11Props])). This change is potentially breaking.useState()-useState()was replaced withuseReducer()to grant better syncs in Concurrent Mode