Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(Dropdown): check refs before focus #2248

Merged
merged 2 commits into from
Jan 23, 2020

Conversation

silviuaavram
Copy link
Collaborator

Check inputRef and buttonRef if they exist before focusing them.

@DustyTheBot
Copy link
Collaborator

DustyTheBot commented Jan 15, 2020

Perf comparison

Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.6 0.41 1.46:1 2000 1196
🔧 Button.Fluent 1.27 0.17 7.47:1 1000 1271
🔧 Checkbox.Fluent 1.45 0.29 5:1 1000 1450
🔧 Dialog.Fluent 0.34 0.18 1.89:1 5000 1706
🔧 Dropdown.Fluent 3.41 0.42 8.12:1 1000 3412
🔧 Icon.Fluent 0.26 0.04 6.5:1 5000 1283
🔧 Image.Fluent 0.11 0.08 1.38:1 5000 564
🔧 Slider.Fluent 1.89 0.29 6.52:1 1000 1885
🦄 Text.Fluent 0.06 0.17 0.35:1 5000 296
🦄 Tooltip.Fluent 0.35 17.99 0.02:1 5000 1758

🔧 Needs work     🎯 On target     🦄 Amazing

Generated by 🚫 dangerJS

Copy link
Contributor

@jurokapsiar jurokapsiar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add changelog entry

@silviuaavram silviuaavram merged commit 5618a4f into master Jan 23, 2020
@silviuaavram silviuaavram deleted the fix/check-refs-before-focus branch January 23, 2020 09:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants