Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(Checkbox): toggle changes width during animation in Teams theme #2189

Merged
merged 2 commits into from
Dec 17, 2019
Merged

fix(Checkbox): toggle changes width during animation in Teams theme #2189

merged 2 commits into from
Dec 17, 2019

Conversation

mnajdova
Copy link
Contributor

Fixes #2144

@mnajdova mnajdova added the 🧰 fix Introduces fix for broken behavior. label Dec 17, 2019
@DustyTheBot
Copy link
Collaborator

Perf comparision

Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
Button.Fluent 1.17 0.12 9.75:1 5000 5835
Checkbox.Fluent 1.32 0.23 5.74:1 5000 6602
Icon.Fluent 0.25 0.03 8.33:1 5000 1258
Slider.Fluent 1.73 0.25 6.92:1 5000 8628

Generated by 🚫 dangerJS

@mnajdova mnajdova merged commit 18634d2 into master Dec 17, 2019
@mnajdova mnajdova deleted the fix/checkbox-toggle-width branch December 17, 2019 12:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@layershifter layershifter layershifter approved these changes

@dvdzkwsk dvdzkwsk Awaiting requested review from dvdzkwsk

@dzearing dzearing Awaiting requested review from dzearing dzearing is a code owner

@ecraig12345 ecraig12345 Awaiting requested review from ecraig12345 ecraig12345 is a code owner

@JasonGore JasonGore Awaiting requested review from JasonGore JasonGore is a code owner

@jdhuntington jdhuntington Awaiting requested review from jdhuntington

@kenotron kenotron Awaiting requested review from kenotron kenotron is a code owner

@levithomason levithomason Awaiting requested review from levithomason levithomason is a code owner

@miroslavstastny miroslavstastny Awaiting requested review from miroslavstastny miroslavstastny is a code owner

Assignees
No one assigned
Labels
🧰 fix Introduces fix for broken behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Checkbox (toggle) changes width during animation
3 participants
@mnajdova @DustyTheBot @layershifter