-
Notifications
You must be signed in to change notification settings - Fork 55
Conversation
|
||
const DividerVerticalExampleShorthand = () => ( | ||
<div style={{ display: 'flex', justifyContent: 'center', height: '32px', alignItems: 'center' }}> | ||
<Divider vertical /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we support vertical Divider with content? Just curious how would it look like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is the case I believe it would complicate the styles in some way, as we will need to "leave space" between the two parts of the divider for the text..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It wasn't a requirement so far. If it's with content then it changes significantly, as it will be | content |
instead of just |
. While the horizontal one is still a one liner. Do you think we need to handle this case now or can it be left for when we really need it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If Teams needs doesn't need this, then it's okay.
e42be2b
to
191ae68
Compare
Divider should now support the
vertical
prop which will position the Divider vertically.Microsoft Reviewers: Open in CodeFlow