Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install docs with SP comments and backend state comments #284

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

TechnicallyWilliams
Copy link
Contributor

@TechnicallyWilliams TechnicallyWilliams commented Sep 6, 2019

All Submissions:


  • [YES] Have you followed the guidelines in our Contributing document?
  • [YES] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [YES] I have updated the documentation accordingly.
  • [NA] I have added tests to cover my changes.
  • [NA] All new and existing tests passed.
  • [NA] My code follows the code style of this project.
  • [NA] I ran lint checks locally prior to submission.
  • [YES] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

What is the current behavior?


Issue Number: [ #277 SP read request to Keyvault secrets fail with access denied ]

What is the new behavior?


  • Documents will prevent fork and go users from copying state from source repo which results in a collision due to shared resources. It will also encourage usage of the same deployment SP for both source and fork and go repo.
  • ADD_PAT_OWNER cli commands have been placed in their own file.
  • An AZDO diagram for guidance on how to name the devops project and repo has been added to ADD_PAT_OWNER_CLI markdown.

Does this introduce a breaking change?


  • [NO]

Any relevant logs, error output, etc?


(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
Deployment errors due to using the same state but diffferent deployment SP from source repo.

Errors as a result of copying state file from source repo.

Deployment Error:
image //
image //...
image

Other information


@TechnicallyWilliams TechnicallyWilliams changed the title Update install docs with SP and backendstate comments Update install docs with SP comments, back end state comments and container validation Sep 12, 2019
@TechnicallyWilliams TechnicallyWilliams changed the title Update install docs with SP comments, back end state comments and container validation Update install docs with SP comments, backend state comments and container validation Sep 12, 2019
@TechnicallyWilliams
Copy link
Contributor Author

Descoping container validation. That issue can be found at #313 ([ Docs ] Document Steps for Container validation)

@TechnicallyWilliams TechnicallyWilliams changed the title Update install docs with SP comments, backend state comments and container validation Update install docs with SP comments and backend state comments Sep 24, 2019
negupt and others added 3 commits September 24, 2019 13:07
* updating readme file

* updating doc

* updating doc

* updating doc

* Force change

Removed last line.
docs/GETTING_STARTED_ADD_PAT_OWNER.md Show resolved Hide resolved
docs/GETTING_STARTED_ADD_PAT_OWNER.md Outdated Show resolved Hide resolved
docs/GETTING_STARTED_ADD_PAT_OWNER.md Outdated Show resolved Hide resolved
docs/GETTING_STARTED_ADD_PAT_OWNER.md Outdated Show resolved Hide resolved
docs/GETTING_STARTED_ADD_PAT_OWNER.md Show resolved Hide resolved
docs/GETTING_STARTED_ADD_PAT_OWNER.md Outdated Show resolved Hide resolved
docs/GETTING_STARTED_ADD_PAT_OWNER.md Show resolved Hide resolved
docs/GETTING_STARTED_ADD_PAT_OWNER.md Outdated Show resolved Hide resolved
docs/GETTING_STARTED_ADD_PAT_OWNER.md Outdated Show resolved Hide resolved
docs/GETTING_STARTED_ADD_PAT_OWNER.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ThePhen ThePhen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @TechnicallyWilliams. This should have been accepted ages ago.

@KeithJRome KeithJRome removed their assignment Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants