Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"winget install microsoft-git" finds entries in msstore #1756

Merged
merged 2 commits into from
Oct 17, 2021

Conversation

Eschryn
Copy link
Contributor

@Eschryn Eschryn commented Oct 15, 2021

To address this: using the id parameter we can make sure it will always install this package.

Original Content:
Adding the source parameter will make sure that the install command will actually install from winget

Adding the source parameter will make sure that the install command will actually install from winget
@derrickstolee
Copy link
Contributor

Hi @Eschryn. Could you explain more about what it means to "find entries in msstore"? This seems like a strange behavior for winget to not use the source that we have specified. The recommended change to add -s winget seems odd and it would be good to have some justification.

@Eschryn
Copy link
Contributor Author

Eschryn commented Oct 15, 2021

Maybe its not reproducible for everyone, but when I run winget install microsoft-git it gives me the following output:

> winget install microsoft-git
Multiple packages found matching input criteria. Please refine the input.
Name          Id            Source
-----------------------------------
Windows Scan  9WZDNCRFJ3PV  msstore
Microsoft Git Microsoft.Git winget

We could use the id instead I suppose.
Not sure why I haven't thought of that immediately.

winget install --id Microsoft.Git

Thats actually better.

@derrickstolee
Copy link
Contributor

derrickstolee commented Oct 15, 2021

Maybe its not reproducible for everyone, but when I run winget install microsoft-git it gives me the following output:

> winget install microsoft-git
Multiple packages found matching input criteria. Please refine the input.
Name          Id            Source
-----------------------------------
Windows Scan  9WZDNCRFJ3PV  msstore
Microsoft Git Microsoft.Git winget

Odd. This doesn't help indicate what exactly is causing your msstore to include something that matches microsoft-git. That's not helpful (and not your fault).

We could use the id instead I suppose. Not sure why I haven't thought of that immediately.

winget install --id Microsoft.Git

Thats actually much better.

I think this is a clearer way to be exact about it without having odd duplication of the word winget.

Edit: We should probably update all of our winget install commands.

@Eschryn
Copy link
Contributor Author

Eschryn commented Oct 15, 2021

I think this is a clearer way to be exact about it without having odd duplication of the word winget.

I will make a change quickly. Kind of weird I didn't think of that at first.

@derrickstolee derrickstolee merged commit 21b52c4 into microsoft:master Oct 17, 2021
derrickstolee added a commit to derrickstolee/git that referenced this pull request Oct 21, 2021
By using the '--id' option, we get around any collisions that might happen
in the msstore. See microsoft/VFSForGit#1756 for a
similar resolution to this problem on that side.

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee added a commit to microsoft/git that referenced this pull request Oct 21, 2021
By using the '--id' option, we get around any collisions that might happen
in the msstore. See microsoft/VFSForGit#1756 for a
similar resolution to this problem on that side.
@vdye vdye mentioned this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants