Mark jsxFactorySymbol as referenced for noUnusedLocals even in verbatimModuleSyntax

[andrewbranch]

Fixes #59117

markJsxAliasReferenced itself checks canCollectSymbolAccessibilityInfo before marking the symbol as referenced for elision purposes (which is not necessary in verbatimModuleSyntax), but marks the symbol as isReferenced for unused locals checking purposes beforehand. That needs to happen unconditionally, but markLinkedReferences bails immediately if canCollectSymbolAccessibilityInfo is false.

I re-read all the changes in #58366 and tried and failed to break other features in combination with verbatimModuleSyntax.

[andrewbranch]

@typescript-bot cherry-pick to release-5.5

[typescript-bot]

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
cherry-pick to release-5.5	✅ Started	✅ Results

[typescript-bot]

Hey, @andrewbranch! I've created #59225 for you.

[jakebailey]

I think this is okay, though it does break the abstraction of markLinkedReferences...

When I was looking at this, what I had found was that the PR that refactored this also modified the behavior to return early from markLinkedReferences, but the old code did not for JSX and for others.

Maybe that early return is what needs to be modified, like jakebailey@29869a9 ?

(That and all of these functions could be moved inside of markLinkedReferences to not be directly callable)

[weswigham]

I think this is okay, though it does break the abstraction of markLinkedReferences...

Yeah, personally, if we think the isReferenced setting behavior is needed independently of the .referenced setting behavior (because it's used for errors and not emit), we should probably pull it out of the whole markLinkedReferences tree of functions and just do it inline.

[weswigham]

(That and all of these functions could be moved inside of markLinkedReferences to not be directly callable)

That had measurably worse performance last I tried, since they all become closures :(