-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dont get declaration diagnostics for file from referenced project #58333
Conversation
Just verifying the playground works with this @typescript-bot pack this |
Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your
and then running There is also a playground for this build and an npm module you can use via |
host, | ||
factory, | ||
compilerOptions, | ||
file ? contains(files, file) ? [file] : emptyArray : files, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Readability nit, but I have a real hard time trying to read this one; is there another way to put this?
let files = filter(getSourceFilesToEmit(host, file), isSourceFileNotJson);
if (file) {
files = contains(files, file) ? [file] : emptyArray;
}
Maybe? If not, no worries, I just have problems reading ternaries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry its hard to read for you. I prefer consts
over let for this. Do you think having it multi line will be more readable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine as it is, no worries.
Fixes #58328