Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont get declaration diagnostics for file from referenced project #58333

Merged
merged 5 commits into from
Apr 26, 2024

Conversation

sheetalkamat
Copy link
Member

Fixes #58328

src/compiler/program.ts Outdated Show resolved Hide resolved
@jakebailey
Copy link
Member

Just verifying the playground works with this

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 26, 2024

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
pack this ✅ Started ✅ Results

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 26, 2024

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/161484/artifacts?artifactName=tgz&fileId=1C3B7BFF6CBB4A613EC6AEE9B252E7058A04A68B8FB501680F0ED376A6E7014B02&fileName=/typescript-5.5.0-insiders.20240426.tgz"
    }
}

and then running npm install.


There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.5.0-pr-58333-2".;

host,
factory,
compilerOptions,
file ? contains(files, file) ? [file] : emptyArray : files,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability nit, but I have a real hard time trying to read this one; is there another way to put this?

let files = filter(getSourceFilesToEmit(host, file), isSourceFileNotJson);
if (file) {
   files = contains(files, file) ? [file] : emptyArray;
}

Maybe? If not, no worries, I just have problems reading ternaries.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry its hard to read for you. I prefer consts over let for this. Do you think having it multi line will be more readable

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine as it is, no worries.

@sheetalkamat sheetalkamat merged commit 1db1376 into main Apr 26, 2024
28 checks passed
@sheetalkamat sheetalkamat deleted the getErr branch April 26, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isolatedDeclarations wrongly enabled in VSCode
5 participants