Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that we are checking if correct file with resolved path is present in the new program when removing the existing packageJson watching #57988

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

sheetalkamat
Copy link
Member

The file's resolved path might not be same if "referenced tsconfig" gets deleted. So we need to ensure that file we get from program has same resolvedPath as what we are looking for, if not remove the existing watched locations
Fixes #57986

…sent in the new program when removing the existing packageJson watching

Fixes #57986
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 28, 2024
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping the first commit would add a baseline for the second to have a diff on, but the first commit shows that there's a debug failure, darn

@sheetalkamat
Copy link
Member Author

Yeah i forgot to generate baseline disabling incremental verifier. Which is what i had done in another PR.

@sheetalkamat sheetalkamat merged commit 12402f2 into main Mar 28, 2024
25 checks passed
@sheetalkamat sheetalkamat deleted the transitive branch March 28, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants