Try making parenthesizeConstituentTypeOfUnionType a no-op #57900

jakebailey · 2024-03-22T00:13:36Z

jakebailey · 2024-03-22T00:13:50Z

@typescript-bot run dt
@typescript-bot perf test this

typescript-bot · 2024-03-22T00:13:52Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`run dt`	✅ Started	👀 Results
`perf test this`	✅ Started	👀 Results

typescript-bot · 2024-03-22T00:33:04Z

Hey @jakebailey, the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: eslint
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/eslint/eslint-tests.ts
   84:1  error  TypeScript@local expected type to be:
  (Token & { type: "Identifier"; }) | null
got:
  Token & { type: "Identifier"; } | null  @definitelytyped/expect
   85:1  error  TypeScript@local expected type to be:
  (Token & { type: "Identifier"; }) | null
got:
  Token & { type: "Identifier"; } | null  @definitelytyped/expect
   90:1  error  TypeScript@local expected type to be:
  (Token & { type: "Identifier"; }) | null
got:
  Token & { type: "Identifier"; } | null  @definitelytyped/expect
  186:1  error  TypeScript@local expected type to be:
  (Token & { type: "Identifier"; }) | null
got:
  Token & { type: "Identifier"; } | null  @definitelytyped/expect
  188:1  error  TypeScript@local expected type to be:
  (Token & { type: "Identifier"; }) | null
got:
  Token & { type: "Identifier"; } | null  @definitelytyped/expect
  198:1  error  TypeScript@local expected type to be:
  (Token & { type: "Identifier"; }) | null
got:
  Token & { type: "Identifier"; } | null  @definitelytyped/expect

✖ 6 problems (6 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.18_typescript@5.5.0-dev.20240321/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.18_typescript@5.5.0-dev.20240321/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: ember__array/v3
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/ember__array/v3/test/array.ts
  33:1  error  TypeScript@local expected type to be:
  ({ name: string; isHappy: boolean; } & EmberObject & { name: string; isHappy: boolean; }) | undefined
got:
  { name: string; isHappy: boolean; } & EmberObject & { name: string; isHappy: boolean; } | undefined  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.18_typescript@5.5.0-dev.20240321/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.18_typescript@5.5.0-dev.20240321/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: parse
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/parse/parse-tests.ts
  1658:9  error  TypeScript@local expected type to be:
  Pointer | (ToJSON<Attributes> & JSONBaseAttributes)
got:
  Pointer | ToJSON<Attributes> & JSONBaseAttributes                  @definitelytyped/expect
  1660:9  error  TypeScript@local expected type to be:
  Pointer | (ToJSON<AttributesAllTypes> & JSONBaseAttributes)
got:
  Pointer | ToJSON<AttributesAllTypes> & JSONBaseAttributes  @definitelytyped/expect

✖ 2 problems (2 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.18_typescript@5.5.0-dev.20240321/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.18_typescript@5.5.0-dev.20240321/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: react/v16
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/react/v16/test/index.ts
  526:13  error  TypeScript@local expected type to be:
  (EventTarget & Element) | null
got:
  EventTarget & Element | null  @definitelytyped/expect
  534:13  error  TypeScript@local expected type to be:
  (EventTarget & Element) | null
got:
  EventTarget & Element | null  @definitelytyped/expect

✖ 2 problems (2 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.18_typescript@5.5.0-dev.20240321/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.18_typescript@5.5.0-dev.20240321/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: ember__array
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/ember__array/test/array.ts
  38:1  error  TypeScript@local expected type to be:
  ({ name: string; isHappy: boolean; } & EmberObject & { name: string; isHappy: boolean; }) | undefined
got:
  { name: string; isHappy: boolean; } & EmberObject & { name: string; isHappy: boolean; } | undefined  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.18_typescript@5.5.0-dev.20240321/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.18_typescript@5.5.0-dev.20240321/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: react/v17
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/react/v17/test/index.ts
  525:13  error  TypeScript@local expected type to be:
  (EventTarget & Element) | null
got:
  EventTarget & Element | null  @definitelytyped/expect
  533:13  error  TypeScript@local expected type to be:
  (EventTarget & Element) | null
got:
  EventTarget & Element | null  @definitelytyped/expect

✖ 2 problems (2 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.18_typescript@5.5.0-dev.20240321/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.18_typescript@5.5.0-dev.20240321/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: react
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/react/test/index.ts
  495:13  error  TypeScript@local expected type to be:
  (EventTarget & Element) | null
got:
  EventTarget & Element | null  @definitelytyped/expect
  503:13  error  TypeScript@local expected type to be:
  (EventTarget & Element) | null
got:
  EventTarget & Element | null  @definitelytyped/expect

✖ 2 problems (2 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.18_typescript@5.5.0-dev.20240321/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.18_typescript@5.5.0-dev.20240321/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: gulp-run
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/gulp-run/gulp-run-tests.ts
  48:5  error  TypeScript@local expected type to be:
  (Error & { status: number; }) | null
got:
  Error & { status: number; } | null  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.18_typescript@5.5.0-dev.20240321/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.18_typescript@5.5.0-dev.20240321/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: wordpress__editor
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/wordpress__editor/wordpress__editor-tests.tsx
  391:1  error  TypeScript@local expected type to be:
  (RenderedText<"edit"> & { is_protected: boolean; block_version: string; }) | (RenderedText<"edit"> & { is_protected: boolean; block_version: string; }) | undefined
got:
  RenderedText<"edit"> & { is_protected: boolean; block_version: string; } | RenderedText<"edit"> & { is_protected: boolean; block_version: string; } | undefined  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.18_typescript@5.5.0-dev.20240321/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.18_typescript@5.5.0-dev.20240321/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

You can check the log here.

typescript-bot · 2024-03-22T00:43:51Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,476k (± 0.01%)}	_{295,465k (± 0.01%)}	_~	_295,442k	_295,499k	_{p=0.470 n=6}
_{Parse Time}	_{3.19s (± 0.62%)}	_{3.21s (± 0.64%)}	_~	_3.18s	_3.24s	_{p=0.413 n=6}
_{Bind Time}	_{1.00s (± 0.52%)}	_{1.00s (± 0.98%)}	_~	_0.99s	_1.01s	_{p=0.931 n=6}
_{Check Time}	_{9.60s (± 0.23%)}	_{9.64s (± 0.39%)}	_~	_9.57s	_9.68s	_{p=0.091 n=6}
_{Emit Time}	_{8.43s (± 0.77%)}	_{8.42s (± 0.34%)}	_~	_8.38s	_8.46s	_{p=0.628 n=6}
_{Total Time}	_{22.22s (± 0.23%)}	_{22.26s (± 0.30%)}	_~	_22.19s	_22.36s	_{p=0.147 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,717k (± 0.95%)}	_{193,226k (± 0.99%)}	_~	_191,858k	_195,692k	_{p=0.936 n=6}
_{Parse Time}	_{1.64s (± 0.99%)}	_{1.64s (± 0.90%)}	_~	_1.62s	_1.66s	_{p=0.870 n=6}
_{Bind Time}	_{0.87s (± 1.84%)}	_{0.86s (± 0.95%)}	_~	_0.85s	_0.87s	_{p=0.065 n=6}
_{Check Time}	_{11.22s (± 0.59%)}	_{11.29s (± 0.71%)}	_~	_11.17s	_11.40s	_{p=0.126 n=6}
_{Emit Time}	_{3.14s (± 0.66%)}	_{3.13s (± 0.48%)}	_~	_3.11s	_3.15s	_{p=0.683 n=6}
_{Total Time}	_{16.88s (± 0.41%)}	_{16.93s (± 0.52%)}	_~	_16.79s	_17.03s	_{p=0.297 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,408k (± 0.01%)}	_{347,371k (± 0.01%)}	_~	_347,337k	_347,408k	_{p=0.054 n=6}
_{Parse Time}	_{3.00s (± 1.10%)}	_{3.01s (± 0.70%)}	_~	_2.97s	_3.03s	_{p=0.629 n=6}
_{Bind Time}	_{1.11s (± 0.37%)}	_{1.11s (± 0.46%)}	_~	_1.11s	_1.12s	_{p=0.595 n=6}
_{Check Time}	_{8.29s (± 0.35%)}	_{8.27s (± 0.49%)}	_~	_8.22s	_8.34s	_{p=0.253 n=6}
_{Emit Time}	_{4.85s (± 0.55%)}	_{4.85s (± 0.24%)}	_~	_4.83s	_4.86s	_{p=0.935 n=6}
_{Total Time}	_{17.25s (± 0.30%)}	_{17.24s (± 0.22%)}	_~	_17.20s	_17.29s	_{p=0.872 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,709k (± 0.01%)}	_{302,705k (± 0.01%)}	_~	_302,669k	_302,755k	_{p=0.936 n=6}
_{Parse Time}	_{2.41s (± 0.85%)}	_{2.40s (± 1.04%)}	_~	_2.36s	_2.43s	_{p=0.685 n=6}
_{Bind Time}	_{1.20s (± 0.34%)}	_{1.18s (± 0.71%)}	_{-0.01s (- 1.11%)}	_1.18s	_1.20s	_{p=0.018 n=6}
_{Check Time}	_{7.48s (± 0.41%)}	_{7.47s (± 0.19%)}	_~	_7.45s	_7.49s	_{p=1.000 n=6}
_{Emit Time}	_{4.27s (± 0.79%)}	_{4.29s (± 0.45%)}	_~	_4.26s	_4.32s	_{p=0.294 n=6}
_{Total Time}	_{15.35s (± 0.37%)}	_{15.34s (± 0.33%)}	_~	_15.25s	_15.40s	_{p=1.000 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{509,901k (± 0.00%)}	_{509,890k (± 0.00%)}	_~	_509,869k	_509,909k	_{p=0.520 n=6}
_{Parse Time}	_{3.19s (± 0.47%)}	_{3.19s (± 0.73%)}	_~	_3.16s	_3.22s	_{p=0.870 n=6}
_{Bind Time}	_{1.17s (± 0.71%)}	_{1.18s (± 0.76%)}	_~	_1.17s	_1.19s	_{p=0.339 n=6}
_{Check Time}	_{20.48s (± 0.29%)}	_{20.49s (± 0.31%)}	_~	_20.42s	_20.60s	_{p=0.871 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{24.84s (± 0.24%)}	_{24.86s (± 0.34%)}	_~	_24.78s	_25.00s	_{p=0.627 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,737,530k (± 0.00%)}	_{1,737,551k (± 0.00%)}	_~	_1,737,508k	_1,737,587k	_{p=0.261 n=6}
_{Parse Time}	_{7.78s (± 0.27%)}	_{7.78s (± 0.45%)}	_~	_7.74s	_7.84s	_{p=0.629 n=6}
_{Bind Time}	_{2.80s (± 1.20%)}	_{2.80s (± 0.35%)}	_~	_2.78s	_2.81s	_{p=0.493 n=6}
_{Check Time}	_{66.53s (± 0.19%)}	_{66.63s (± 0.38%)}	_~	_66.36s	_66.96s	_{p=0.575 n=6}
_{Emit Time}	_{0.16s (± 3.29%)}	_{0.16s (± 3.29%)}	_~	_0.15s	_0.16s	_{p=1.000 n=6}
_{Total Time}	_{77.27s (± 0.17%)}	_{77.37s (± 0.33%)}	_~	_77.10s	_77.75s	_{p=0.689 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,394,391k (± 0.04%)}	_{2,393,599k (± 0.05%)}	_~	_2,392,471k	_2,395,076k	_{p=0.230 n=6}
_{Parse Time}	_{6.07s (± 0.95%)}	_{6.04s (± 0.37%)}	_~	_6.00s	_6.06s	_{p=0.064 n=6}
_{Bind Time}	_{2.24s (± 1.23%)}	_{2.26s (± 0.97%)}	_~	_2.23s	_2.29s	_{p=0.195 n=6}
_{Check Time}	_{39.48s (± 0.46%)}	_{39.47s (± 0.40%)}	_~	_39.25s	_39.62s	_{p=0.873 n=6}
_{Emit Time}	_{3.10s (± 1.40%)}	_{3.11s (± 1.06%)}	_~	_3.07s	_3.16s	_{p=0.571 n=6}
_{Total Time}	_{50.90s (± 0.36%)}	_{50.89s (± 0.31%)}	_~	_50.68s	_51.07s	_{p=0.810 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{415,211k (± 0.00%)}	_{415,181k (± 0.01%)}	_~	_415,129k	_415,219k	_{p=0.199 n=6}
_{Parse Time}	_{3.42s (± 0.49%)}	_{3.43s (± 0.84%)}	_~	_3.40s	_3.48s	_{p=1.000 n=6}
_{Bind Time}	_{1.29s (± 0.80%)}	_{1.29s (± 0.40%)}	_~	_1.28s	_1.29s	_{p=0.928 n=6}
_{Check Time}	_{18.09s (± 0.49%)}	_{17.98s (± 0.36%)}	_~	_17.89s	_18.05s	_{p=0.065 n=6}
_{Emit Time}	_{1.34s (± 1.15%)}	_{1.32s (± 1.23%)}	_~	_1.30s	_1.34s	_{p=0.145 n=6}
_{Total Time}	_{24.13s (± 0.41%)}	_{24.02s (± 0.28%)}	_~	_23.93s	_24.09s	_{p=0.065 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,889,693k (± 0.00%)}	_{2,889,664k (± 0.00%)}	_~	_2,889,521k	_2,889,737k	_{p=0.471 n=6}
_{Parse Time}	_{10.81s (± 0.06%)}	_{10.84s (± 0.34%)}	_~	_10.78s	_10.88s	_{p=0.157 n=6}
_{Bind Time}	_{3.45s (± 0.40%)}	_{3.43s (± 0.24%)}	_~	_3.42s	_3.44s	_{p=0.183 n=6}
_{Check Time}	_{61.46s (± 0.30%)}	_{61.39s (± 0.21%)}	_~	_61.21s	_61.52s	_{p=0.686 n=6}
_{Emit Time}	_{16.38s (± 0.51%)}	_{16.40s (± 0.64%)}	_~	_16.26s	_16.53s	_{p=0.748 n=6}
_{Total Time}	_{92.09s (± 0.25%)}	_{92.06s (± 0.24%)}	_~	_91.69s	_92.24s	_{p=0.810 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{408,093k (± 0.01%)}	_{408,097k (± 0.01%)}	_~	_408,035k	_408,166k	_{p=1.000 n=6}
_{Parse Time}	_{3.90s (± 0.53%)}	_{3.90s (± 0.39%)}	_~	_3.88s	_3.92s	_{p=0.511 n=6}
_{Bind Time}	_{1.66s (± 1.17%)}	_{1.68s (± 0.58%)}	_{+0.02s (+ 1.41%)}	_1.67s	_1.69s	_{p=0.048 n=6}
_{Check Time}	_{16.72s (± 0.45%)}	_{16.73s (± 0.27%)}	_~	_16.67s	_16.79s	_{p=1.000 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.28s (± 0.32%)}	_{22.32s (± 0.23%)}	_~	_22.26s	_22.39s	_{p=0.375 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,102k (± 0.02%)}	_{513,044k (± 0.02%)}	_~	_512,916k	_513,178k	_{p=0.423 n=6}
_{Parse Time}	_{3.94s (± 0.94%)}	_{3.96s (± 0.46%)}	_~	_3.93s	_3.98s	_{p=0.170 n=6}
_{Bind Time}	_{1.85s (± 0.99%)}	_{1.85s (± 0.72%)}	_~	_1.83s	_1.86s	_{p=1.000 n=6}
_{Check Time}	_{3.38s (± 0.37%)}	_{3.37s (± 0.36%)}	_~	_3.36s	_3.39s	_{p=0.565 n=6}
_{Emit Time}	_{0.09s (± 6.44%)}	_{0.09s (± 5.95%)}	_~	_0.08s	_0.09s	_{p=0.640 n=6}
_{Total Time}	_{9.26s (± 0.47%)}	_{9.27s (± 0.25%)}	_~	_9.23s	_9.30s	_{p=0.199 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,881ms (± 0.19%)}	_{2,877ms (± 0.41%)}	_~	_2,857ms	_2,893ms	_{p=0.575 n=6}
_{Req 2 - geterr}	_{6,723ms (± 0.54%)}	_{6,703ms (± 0.47%)}	_~	_6,666ms	_6,742ms	_{p=0.230 n=6}
_{Req 3 - references}	_{401ms (± 9.16%)}	_{391ms (± 1.56%)}	_~	_384ms	_397ms	_{p=0.378 n=6}
_{Req 4 - navto}	_{347ms (± 8.58%)}	_{335ms (± 0.19%)}	_~	_334ms	_336ms	_{p=0.654 n=6}
_{Req 5 - completionInfo count}	_{1,357 (± 0.00%)}	_{1,357 (± 0.00%)}	_~	_1,357	_1,357	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{107ms (±10.75%)}	_{102ms (± 4.26%)}	_~	_96ms	_105ms	_{p=0.332 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,501ms (± 1.09%)}	_{2,504ms (± 1.34%)}	_~	_2,457ms	_2,562ms	_{p=0.936 n=6}
_{Req 2 - geterr}	_{4,105ms (± 0.25%)}	_{4,111ms (± 0.18%)}	_~	_4,102ms	_4,122ms	_{p=0.225 n=6}
_{Req 3 - references}	_{333ms (± 0.41%)}	_{334ms (± 0.70%)}	_~	_333ms	_339ms	_{p=0.800 n=6}
_{Req 4 - navto}	_{294ms (± 0.14%)}	_{299ms (± 3.48%)}	_~	_294ms	_320ms	_{p=0.214 n=6}
_{Req 5 - completionInfo count}	_{1,519 (± 0.00%)}	_{1,519 (± 0.00%)}	_~	_1,519	_1,519	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{74ms (± 0.70%)}	_{74ms (± 0.55%)}	_~	_73ms	_74ms	_{p=0.595 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,606ms (± 0.75%)}	_{2,611ms (± 0.47%)}	_~	_2,587ms	_2,621ms	_{p=0.521 n=6}
_{Req 2 - geterr}	_{1,708ms (± 2.46%)}	_{1,741ms (± 1.39%)}	_~	_1,701ms	_1,774ms	_{p=0.149 n=6}
_{Req 3 - references}	_{115ms (±10.83%)}	_{117ms (± 9.60%)}	_~	_102ms	_125ms	_{p=0.515 n=6}
_{Req 4 - navto}	_{368ms (± 1.35%)}	_{372ms (± 2.63%)}	_~	_361ms	_390ms	_{p=0.468 n=6}
_{Req 5 - completionInfo count}	_{2,079 (± 0.00%)}	_{2,079 (± 0.00%)}	_~	_2,079	_2,079	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{307ms (± 1.48%)}	_{310ms (± 1.59%)}	_~	_303ms	_316ms	_{p=0.375 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{152.32ms (± 0.17%)}	_{152.29ms (± 0.21%)}	_{-0.04ms (- 0.03%)}	_151.19ms	_156.32ms	_{p=0.003 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{226.10ms (± 0.18%)}	_{226.08ms (± 0.20%)}	_~	_224.62ms	_238.69ms	_{p=0.178 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{221.52ms (± 0.16%)}	_{221.48ms (± 0.15%)}	_~	_219.99ms	_225.89ms	_{p=0.296 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{220.80ms (± 0.16%)}	_{220.78ms (± 0.14%)}	_~	_219.32ms	_222.88ms	_{p=0.703 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

jakebailey · 2024-03-22T00:47:09Z

Actually not that bad

weswigham · 2024-03-22T01:02:01Z

Only 9 breaks on DT? Really not that bad.

rubiesonthesky · 2024-03-22T11:39:30Z

...reference/extractFunction/extractFunction_VariableDeclaration_Writes_Let_TypeWithComments.ts

@@ -23,7 +23,7 @@ function f() {

 function f() {
    let a = 1;
-    let x: (/*A*/ "a" /*B*/ | /*C*/ 'b' /*D*/) | undefined;
+    let x: /*A*/ /*A*/ "a" /*B*/ | /*C*/ 'b' /*D*/ | undefined;


This extra /*A*/ is curious

Presumably we added logic to copy the leading comment range from the union itself onto the inner "a" when we added the (), but with the () no longer being added, we also no longer need to copy the comment range from the union node to the "a", since the union node isn't getting remade.

Any guesses as to where that logic might be?

Based on how extractSymbol works, probably some of the comment suppression/copying logic for getSynthesizedDeepClone or getTypeDeepCloneUnionUndefined.

Try making parenthesizeConstituentTypeOfUnionType a no-op

90bda7f

typescript-bot assigned jakebailey Mar 22, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 22, 2024

rubiesonthesky reviewed Mar 22, 2024

View reviewed changes

jakebailey mentioned this pull request Mar 22, 2024

Apply same single-line style to copied nodes as manufactured ones #57890

Merged

jakebailey added 2 commits April 2, 2024 15:28

Merge branch 'main' into no-paren-rule-unions

7e94692

Merge branch 'main' into no-paren-rule-unions

2c30cee

jakebailey closed this Jul 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Try making parenthesizeConstituentTypeOfUnionType a no-op #57900

Try making parenthesizeConstituentTypeOfUnionType a no-op #57900

jakebailey commented Mar 22, 2024

jakebailey commented Mar 22, 2024

typescript-bot commented Mar 22, 2024 •

edited

Loading

typescript-bot commented Mar 22, 2024

typescript-bot commented Mar 22, 2024

tsc

tsserver

startup

jakebailey commented Mar 22, 2024

weswigham commented Mar 22, 2024

rubiesonthesky Mar 22, 2024

weswigham Mar 22, 2024

jakebailey Mar 22, 2024

weswigham Mar 26, 2024

Try making parenthesizeConstituentTypeOfUnionType a no-op #57900

Try making parenthesizeConstituentTypeOfUnionType a no-op #57900

Conversation

jakebailey commented Mar 22, 2024

jakebailey commented Mar 22, 2024

typescript-bot commented Mar 22, 2024 • edited Loading

typescript-bot commented Mar 22, 2024

typescript-bot commented Mar 22, 2024

tsc

tsserver

startup

jakebailey commented Mar 22, 2024

weswigham commented Mar 22, 2024

rubiesonthesky Mar 22, 2024

Choose a reason for hiding this comment

weswigham Mar 22, 2024

Choose a reason for hiding this comment

jakebailey Mar 22, 2024

Choose a reason for hiding this comment

weswigham Mar 26, 2024

Choose a reason for hiding this comment

typescript-bot commented Mar 22, 2024 •

edited

Loading