When relating a deferred index type over a mapped type on the source side ... #56742

weswigham · 2023-12-11T20:59:32Z

actually compare against the mapped type's apparent keys.

FIxes #56718 - the emit is fine (all the anonymous/local types are inlined and duplicated like you'd expect), our relationship logic was just too strict when relating deferred index types of mapped types, so in the emit, when the keyof {big anonymous mapped type} got duplicated into two places, we failed to recognize them as the same type.

…side, actually compare against the mapped type's apparent keys

weswigham · 2023-12-11T21:02:03Z

@typescript-bot test this
@typescript-bot run dt
@typescript-bot test top100
@typescript-bot perf test this
@typescript-bot pack this

typescript-bot · 2023-12-11T21:02:06Z

Heya @weswigham, I've started to run the regular perf test suite on this PR at b6e3704. You can monitor the build here.

typescript-bot · 2023-12-11T21:02:06Z

Heya @weswigham, I've started to run the diff-based top-repos suite on this PR at b6e3704. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-12-11T21:02:06Z

Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at b6e3704. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-12-11T21:02:06Z

Heya @weswigham, I've started to run the tarball bundle task on this PR at b6e3704. You can monitor the build here.

typescript-bot · 2023-12-11T21:03:46Z

Hey @weswigham, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/159064/artifacts?artifactName=tgz&fileId=81A960F26A44587A8544C1550501F826DB3C1BB10B2682D1516117907403737F02&fileName=/typescript-5.4.0-insiders.20231211.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.4.0-pr-56742-5".;

typescript-bot · 2023-12-11T21:31:24Z

Hey @weswigham, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2023-12-11T22:04:11Z

@weswigham Here are the results of running the top-repos suite comparing main and refs/pull/56742/merge:

Everything looks good!

jakebailey · 2023-12-11T22:10:57Z

@typescript-bot perf test this

typescript-bot · 2023-12-11T22:11:00Z

Heya @jakebailey, I've started to run the regular perf test suite on this PR at 682b7d3. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-12-11T22:43:50Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,356k (± 0.02%)}	_{295,368k (± 0.01%)}	_~	_295,355k	_295,393k	_{p=1.000 n=6}
_{Parse Time}	_{2.64s (± 0.41%)}	_{2.65s (± 0.21%)}	_~	_2.64s	_2.65s	_{p=0.476 n=6}
_{Bind Time}	_{0.82s (± 0.50%)}	_{0.82s (± 0.00%)}	_~	_0.82s	_0.82s	_{p=0.405 n=6}
_{Check Time}	_{8.13s (± 0.40%)}	_{8.11s (± 0.31%)}	_~	_8.07s	_8.14s	_{p=0.288 n=6}
_{Emit Time}	_{7.10s (± 0.30%)}	_{7.08s (± 0.27%)}	_~	_7.07s	_7.12s	_{p=0.256 n=6}
_{Total Time}	_{18.69s (± 0.17%)}	_{18.66s (± 0.15%)}	_~	_18.61s	_18.69s	_{p=0.170 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{195,296k (± 1.53%)}	_{193,398k (± 1.56%)}	_~	_191,450k	_197,305k	_{p=0.810 n=6}
_{Parse Time}	_{1.36s (± 1.20%)}	_{1.35s (± 0.38%)}	_~	_1.35s	_1.36s	_{p=0.933 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.27s (± 0.29%)}	_{9.31s (± 0.52%)}	_~	_9.22s	_9.36s	_{p=0.076 n=6}
_{Emit Time}	_{2.61s (± 0.46%)}	_{2.62s (± 0.84%)}	_~	_2.60s	_2.66s	_{p=0.800 n=6}
_{Total Time}	_{13.97s (± 0.17%)}	_{14.01s (± 0.42%)}	_~	_13.91s	_14.09s	_{p=0.088 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,374k (± 0.01%)}	_{347,354k (± 0.01%)}	_~	_347,332k	_347,397k	_{p=0.229 n=6}
_{Parse Time}	_{2.46s (± 0.17%)}	_{2.45s (± 0.26%)}	_{-0.01s (- 0.47%)}	_2.44s	_2.46s	_{p=0.009 n=6}
_{Bind Time}	_{0.93s (± 0.44%)}	_{0.92s (± 0.56%)}	_~	_0.92s	_0.93s	_{p=0.112 n=6}
_{Check Time}	_{6.90s (± 0.48%)}	_{6.90s (± 0.35%)}	_~	_6.86s	_6.92s	_{p=0.685 n=6}
_{Emit Time}	_{4.05s (± 0.36%)}	_{4.05s (± 0.35%)}	_~	_4.03s	_4.07s	_{p=1.000 n=6}
_{Total Time}	_{14.34s (± 0.29%)}	_{14.32s (± 0.22%)}	_~	_14.28s	_14.35s	_{p=0.418 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,649k (± 0.00%)}	_{302,634k (± 0.00%)}	_{-16k (- 0.01%)}	_302,621k	_302,645k	_{p=0.037 n=6}
_{Parse Time}	_{2.00s (± 1.08%)}	_{2.01s (± 0.94%)}	_~	_1.99s	_2.03s	_{p=0.618 n=6}
_{Bind Time}	_{1.00s (± 1.09%)}	_{0.99s (± 0.55%)}	_~	_0.99s	_1.00s	_{p=0.476 n=6}
_{Check Time}	_{6.28s (± 0.33%)}	_{6.27s (± 0.36%)}	_~	_6.23s	_6.29s	_{p=0.466 n=6}
_{Emit Time}	_{3.58s (± 0.61%)}	_{3.59s (± 0.72%)}	_~	_3.54s	_3.61s	_{p=0.328 n=6}
_{Total Time}	_{12.86s (± 0.31%)}	_{12.86s (± 0.34%)}	_~	_12.79s	_12.91s	_{p=1.000 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{506,796k (± 0.00%)}	_{506,750k (± 0.00%)}	_{-46k (- 0.01%)}	_506,724k	_506,782k	_{p=0.013 n=6}
_{Parse Time}	_{2.58s (± 0.72%)}	_{2.58s (± 0.68%)}	_~	_2.56s	_2.61s	_{p=0.871 n=6}
_{Bind Time}	_{0.99s (± 1.23%)}	_{0.99s (± 1.05%)}	_~	_0.97s	_1.00s	_{p=1.000 n=6}
_{Check Time}	_{16.89s (± 0.56%)}	_{16.90s (± 0.55%)}	_~	_16.76s	_17.02s	_{p=0.630 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.45s (± 0.41%)}	_{20.47s (± 0.45%)}	_~	_20.31s	_20.56s	_{p=0.574 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,813k (± 0.01%)}	_{512,846k (± 0.01%)}	_{+33k (+ 0.01%)}	_512,806k	_512,933k	_{p=0.045 n=6}
_{Parse Time}	_{3.27s (± 0.32%)}	_{3.27s (± 0.36%)}	_~	_3.26s	_3.29s	_{p=0.801 n=6}
_{Bind Time}	_{1.54s (± 0.54%)}	_{1.54s (± 0.36%)}	_~	_1.53s	_1.54s	_{p=0.855 n=6}
_{Check Time}	_{2.80s (± 0.37%)}	_{2.81s (± 0.75%)}	_~	_2.79s	_2.84s	_{p=0.871 n=6}
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 5.69%)}	_~	_0.07s	_0.08s	_{p=0.405 n=6}
_{Total Time}	_{7.69s (± 0.10%)}	_{7.69s (± 0.20%)}	_~	_7.67s	_7.71s	_{p=0.864 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,345ms (± 0.82%)}	_{2,341ms (± 0.32%)}	_~	_2,331ms	_2,352ms	_{p=1.000 n=6}
_{Req 2 - geterr}	_{5,428ms (± 1.36%)}	_{5,452ms (± 1.38%)}	_~	_5,376ms	_5,540ms	_{p=0.261 n=6}
_{Req 3 - references}	_{324ms (± 0.77%)}	_{337ms (± 7.47%)}	_~	_323ms	_388ms	_{p=0.166 n=6}
_{Req 4 - navto}	_{276ms (± 1.25%)}	_{273ms (± 1.88%)}	_~	_263ms	_277ms	_{p=0.300 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{89ms (± 6.27%)}	_{85ms (± 8.01%)}	_~	_77ms	_92ms	_{p=0.121 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,492ms (± 0.42%)}	_{2,476ms (± 0.76%)}	_~	_2,448ms	_2,498ms	_{p=0.128 n=6}
_{Req 2 - geterr}	_{4,085ms (± 1.59%)}	_{4,167ms (± 1.85%)}	_~	_4,059ms	_4,231ms	_{p=0.128 n=6}
_{Req 3 - references}	_{345ms (± 0.62%)}	_{338ms (± 1.50%)}	_{-7ms (- 2.08%)}	_334ms	_345ms	_{p=0.015 n=6}
_{Req 4 - navto}	_{285ms (± 0.34%)}	_{285ms (± 1.25%)}	_~	_282ms	_292ms	_{p=0.618 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{89ms (± 0.71%)}	_{83ms (± 7.26%)}	_~	_77ms	_89ms	_{p=0.059 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,600ms (± 0.56%)}	_{2,595ms (± 0.93%)}	_~	_2,565ms	_2,619ms	_{p=0.872 n=6}
_{Req 2 - geterr}	_{1,694ms (± 2.42%)}	_{1,697ms (± 2.78%)}	_~	_1,642ms	_1,758ms	_{p=1.000 n=6}
_{Req 3 - references}	_{116ms (± 8.85%)}	_{116ms (± 8.82%)}	_~	_102ms	_123ms	_{p=0.934 n=6}
_{Req 4 - navto}	_{365ms (± 0.55%)}	_{365ms (± 0.17%)}	_~	_364ms	_366ms	_{p=0.262 n=6}
_{Req 5 - completionInfo count}	_{2,073 (± 0.00%)}	_{2,073 (± 0.00%)}	_~	_2,073	_2,073	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{307ms (± 1.81%)}	_{309ms (± 1.57%)}	_~	_302ms	_313ms	_{p=1.000 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{153.09ms (± 0.21%)}	_{152.97ms (± 0.18%)}	_{-0.12ms (- 0.08%)}	_151.79ms	_155.66ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.58ms (± 0.16%)}	_{228.56ms (± 0.19%)}	_~	_227.36ms	_241.89ms	_{p=0.134 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.82ms (± 0.18%)}	_{229.83ms (± 0.19%)}	_~	_228.27ms	_236.43ms	_{p=0.704 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.50ms (± 0.18%)}	_{229.69ms (± 0.18%)}	_{+0.19ms (+ 0.08%)}	_228.12ms	_232.50ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

src/compiler/checker.ts

When relating a deferred index type over a mapped type on the source …

b6e3704

…side, actually compare against the mapped type's apparent keys

typescript-bot assigned weswigham Dec 11, 2023

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Dec 11, 2023

Add missing semicolon

682b7d3

weswigham requested review from andrewbranch and ahejlsberg December 11, 2023 21:42

jakebailey approved these changes Dec 14, 2023

View reviewed changes

gabritto reviewed Dec 14, 2023

View reviewed changes

src/compiler/checker.ts Show resolved Hide resolved

DanielRosenwasser mentioned this pull request Dec 15, 2023

Design Meeting Notes, 12/13/2023 #56798

Closed

weswigham merged commit bc74ec4 into microsoft:main Jan 9, 2024
19 checks passed

weswigham mentioned this pull request Jan 9, 2024

Improve relationship checking with keyof GenericMappedType as the source type #56246

Open

Andarist mentioned this pull request Jan 26, 2024

[5.4 regression] Broken relation of deferred index type over a mapped type on the source side #57188

Closed

RyanCavanaugh mentioned this pull request Mar 18, 2024

Extract not narrowing type union in mapped type passed as generic #57827

Open

Andarist mentioned this pull request Mar 18, 2024

Fixed an issue with apparent mapped type keys #57838

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

When relating a deferred index type over a mapped type on the source side ... #56742

When relating a deferred index type over a mapped type on the source side ... #56742

weswigham commented Dec 11, 2023 •

edited

Loading

weswigham commented Dec 11, 2023

typescript-bot commented Dec 11, 2023 •

edited

Loading

typescript-bot commented Dec 11, 2023 •

edited

Loading

typescript-bot commented Dec 11, 2023 •

edited

Loading

typescript-bot commented Dec 11, 2023 •

edited

Loading

typescript-bot commented Dec 11, 2023 •

edited

Loading

typescript-bot commented Dec 11, 2023

typescript-bot commented Dec 11, 2023

jakebailey commented Dec 11, 2023

typescript-bot commented Dec 11, 2023 •

edited

Loading

typescript-bot commented Dec 11, 2023

Compiler

tsserver

Startup

When relating a deferred index type over a mapped type on the source side ... #56742

When relating a deferred index type over a mapped type on the source side ... #56742

Conversation

weswigham commented Dec 11, 2023 • edited Loading

weswigham commented Dec 11, 2023

typescript-bot commented Dec 11, 2023 • edited Loading

typescript-bot commented Dec 11, 2023 • edited Loading

typescript-bot commented Dec 11, 2023 • edited Loading

typescript-bot commented Dec 11, 2023 • edited Loading

typescript-bot commented Dec 11, 2023 • edited Loading

typescript-bot commented Dec 11, 2023

typescript-bot commented Dec 11, 2023

jakebailey commented Dec 11, 2023

typescript-bot commented Dec 11, 2023 • edited Loading

typescript-bot commented Dec 11, 2023

Compiler

tsserver

Startup

weswigham commented Dec 11, 2023 •

edited

Loading

typescript-bot commented Dec 11, 2023 •

edited

Loading

typescript-bot commented Dec 11, 2023 •

edited

Loading

typescript-bot commented Dec 11, 2023 •

edited

Loading

typescript-bot commented Dec 11, 2023 •

edited

Loading

typescript-bot commented Dec 11, 2023 •

edited

Loading

typescript-bot commented Dec 11, 2023 •

edited

Loading