Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve JSDocFunctionType readability #56694

Merged

Conversation

sandersn
Copy link
Member

@sandersn sandersn commented Dec 6, 2023

Replace a single-token lookahead+nextToken with a tryParse. Easier to read and avoids redoing a tiny bit of work.

Noticed this while preparing a talk on the parser.

Replace a single-token lookahead+nextToken with a tryParse.
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Dec 6, 2023
@sandersn sandersn merged commit 3d11251 into microsoft:main Dec 6, 2023
19 checks passed
@sandersn sandersn deleted the improve-parseJSDocFunctionType-readability branch December 6, 2023 23:32
c0sta pushed a commit to c0sta/TypeScript that referenced this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants