Fixed types of properties of contextual filtering mapped types #56201

Andarist · 2023-10-24T07:15:01Z

This is based on the contextualPropertyOfGenericMappedType test case - just with the added filtering .nameType

typescript-bot · 2023-10-24T07:15:07Z

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

RyanCavanaugh · 2023-10-24T16:52:15Z

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test tsserver top100
@typescript-bot run dt
@typescript-bot perf test this
@typescript-bot pack this

typescript-bot · 2023-10-24T16:52:18Z

Heya @RyanCavanaugh, I've started to run the tarball bundle task on this PR at 546f5d7. You can monitor the build here.

typescript-bot · 2023-10-24T16:52:18Z

Heya @RyanCavanaugh, I've started to run the parallelized Definitely Typed test suite on this PR at 546f5d7. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-10-24T16:52:18Z

Heya @RyanCavanaugh, I've started to run the diff-based user code test suite (tsserver) on this PR at 546f5d7. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-10-24T16:52:18Z

Heya @RyanCavanaugh, I've started to run the diff-based top-repos suite on this PR at 546f5d7. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-10-24T16:52:18Z

Heya @RyanCavanaugh, I've started to run the diff-based top-repos suite (tsserver) on this PR at 546f5d7. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-10-24T16:52:18Z

Heya @RyanCavanaugh, I've started to run the regular perf test suite on this PR at 546f5d7. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-10-24T16:52:18Z

Heya @RyanCavanaugh, I've started to run the diff-based user code test suite on this PR at 546f5d7. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-10-24T16:54:24Z

Hey @RyanCavanaugh, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/158327/artifacts?artifactName=tgz&fileId=027BC9B658787EB39EEF320DDC8C76612CCC5A7F7458CEA8DAA28ED4E9C7C0BC02&fileName=/typescript-5.3.0-insiders.20231024.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.3.0-pr-56201-9".;

typescript-bot · 2023-10-24T17:07:31Z

@RyanCavanaugh Here are the results of running the user test suite comparing main and refs/pull/56201/merge:

Everything looks good!

typescript-bot · 2023-10-24T17:10:43Z

@RyanCavanaugh Here are the results of running the user test suite comparing main and refs/pull/56201/merge:

There were infrastructure failures potentially unrelated to your change:

3 instances of "Package install failed"
1 instance of "Unknown failure"

Otherwise...

Everything looks good!

typescript-bot · 2023-10-24T17:17:22Z

@RyanCavanaugh
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,114k (± 0.01%)}	_{295,125k (± 0.01%)}	_~	_295,086k	_295,174k	_{p=0.872 n=6}
_{Parse Time}	_{2.63s (± 0.31%)}	_{2.63s (± 0.64%)}	_~	_2.60s	_2.65s	_{p=1.000 n=6}
_{Bind Time}	_{0.83s (± 0.66%)}	_{0.84s (± 0.97%)}	_~	_0.83s	_0.85s	_{p=0.859 n=6}
_{Check Time}	_{8.05s (± 0.28%)}	_{8.05s (± 0.19%)}	_~	_8.03s	_8.07s	_{p=0.565 n=6}
_{Emit Time}	_{7.09s (± 0.68%)}	_{7.07s (± 0.24%)}	_~	_7.05s	_7.10s	_{p=0.413 n=6}
_{Total Time}	_{18.62s (± 0.29%)}	_{18.58s (± 0.10%)}	_~	_18.57s	_18.62s	_{p=0.222 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,601k (± 1.65%)}	_{191,632k (± 1.22%)}	_~	_190,652k	_196,417k	_{p=0.261 n=6}
_{Parse Time}	_{1.34s (± 1.12%)}	_{1.34s (± 0.90%)}	_~	_1.32s	_1.35s	_{p=0.675 n=6}
_{Bind Time}	_{0.73s (± 0.00%)}	_{0.73s (± 0.00%)}	_~	_0.73s	_0.73s	_{p=1.000 n=6}
_{Check Time}	_{9.17s (± 0.35%)}	_{9.18s (± 0.56%)}	_~	_9.11s	_9.25s	_{p=0.686 n=6}
_{Emit Time}	_{2.64s (± 0.54%)}	_{2.64s (± 0.44%)}	_~	_2.62s	_2.65s	_{p=0.934 n=6}
_{Total Time}	_{13.88s (± 0.30%)}	_{13.89s (± 0.37%)}	_~	_13.82s	_13.95s	_{p=0.809 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,362k (± 0.01%)}	_{347,368k (± 0.00%)}	_~	_347,360k	_347,386k	_{p=0.630 n=6}
_{Parse Time}	_{2.46s (± 0.42%)}	_{2.46s (± 0.17%)}	_~	_2.46s	_2.47s	_{p=0.390 n=6}
_{Bind Time}	_{0.94s (± 0.00%)}	_{0.94s (± 0.43%)}	_~	_0.93s	_0.94s	_{p=0.405 n=6}
_{Check Time}	_{6.92s (± 0.55%)}	_{6.92s (± 0.38%)}	_~	_6.89s	_6.96s	_{p=0.747 n=6}
_{Emit Time}	_{4.05s (± 0.50%)}	_{4.05s (± 0.30%)}	_~	_4.04s	_4.07s	_{p=0.622 n=6}
_{Total Time}	_{14.37s (± 0.32%)}	_{14.38s (± 0.16%)}	_~	_14.35s	_14.41s	_{p=0.520 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,599k (± 0.01%)}	_{302,606k (± 0.01%)}	_~	_302,580k	_302,648k	_{p=0.748 n=6}
_{Parse Time}	_{1.98s (± 0.90%)}	_{2.00s (± 1.03%)}	_~	_1.98s	_2.04s	_{p=0.062 n=6}
_{Bind Time}	_{1.00s (± 0.81%)}	_{1.01s (± 1.40%)}	_~	_0.99s	_1.03s	_{p=0.402 n=6}
_{Check Time}	_{6.28s (± 0.42%)}	_{6.26s (± 0.37%)}	_~	_6.23s	_6.29s	_{p=0.147 n=6}
_{Emit Time}	_{3.57s (± 0.55%)}	_{3.57s (± 0.29%)}	_~	_3.56s	_3.59s	_{p=1.000 n=6}
_{Total Time}	_{12.84s (± 0.16%)}	_{12.85s (± 0.19%)}	_~	_12.82s	_12.88s	_{p=0.744 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{470,516k (± 0.00%)}	_{470,517k (± 0.00%)}	_~	_470,490k	_470,546k	_{p=1.000 n=6}
_{Parse Time}	_{2.57s (± 0.75%)}	_{2.56s (± 0.48%)}	_~	_2.55s	_2.58s	_{p=0.503 n=6}
_{Bind Time}	_{0.99s (± 0.64%)}	_{0.99s (± 0.64%)}	_~	_0.98s	_1.00s	_{p=1.000 n=6}
_{Check Time}	_{16.62s (± 0.44%)}	_{16.59s (± 0.49%)}	_~	_16.48s	_16.71s	_{p=0.630 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.18s (± 0.38%)}	_{20.14s (± 0.42%)}	_~	_20.03s	_20.27s	_{p=0.573 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,641k (± 0.01%)}	_{512,589k (± 0.01%)}	_~	_512,536k	_512,711k	_{p=0.128 n=6}
_{Parse Time}	_{3.26s (± 0.42%)}	_{3.28s (± 0.32%)}	_~	_3.26s	_3.29s	_{p=0.160 n=6}
_{Bind Time}	_{1.55s (± 0.26%)}	_{1.55s (± 0.41%)}	_~	_1.54s	_1.56s	_{p=0.673 n=6}
_{Check Time}	_{2.86s (± 0.60%)}	_{2.84s (± 0.70%)}	_~	_2.81s	_2.87s	_{p=0.063 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{7.74s (± 0.28%)}	_{7.73s (± 0.32%)}	_~	_7.70s	_7.77s	_{p=0.625 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,389ms (± 1.11%)}	_{2,346ms (± 1.48%)}	_~	_2,320ms	_2,412ms	_{p=0.066 n=6}
_{Req 2 - geterr}	_{5,341ms (± 1.58%)}	_{5,410ms (± 1.57%)}	_~	_5,319ms	_5,507ms	_{p=0.093 n=6}
_{Req 3 - references}	_{328ms (± 1.65%)}	_{328ms (± 0.96%)}	_~	_326ms	_334ms	_{p=0.561 n=6}
_{Req 4 - navto}	_{276ms (± 1.38%)}	_{275ms (± 1.60%)}	_~	_271ms	_280ms	_{p=0.935 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{82ms (± 8.33%)}	_{82ms (± 9.25%)}	_~	_75ms	_91ms	_{p=1.000 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,477ms (± 0.94%)}	_{2,462ms (± 1.51%)}	_~	_2,425ms	_2,513ms	_{p=0.518 n=6}
_{Req 2 - geterr}	_{4,082ms (± 1.59%)}	_{4,133ms (± 2.00%)}	_~	_4,049ms	_4,218ms	_{p=0.378 n=6}
_{Req 3 - references}	_{341ms (± 1.06%)}	_{338ms (± 1.49%)}	_~	_332ms	_343ms	_{p=0.112 n=6}
_{Req 4 - navto}	_{285ms (± 0.29%)}	_{284ms (± 0.35%)}	_~	_283ms	_285ms	_{p=0.256 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{84ms (± 4.77%)}	_{82ms (± 8.04%)}	_~	_75ms	_88ms	_{p=0.737 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,587ms (± 0.70%)}	_{2,597ms (± 0.44%)}	_~	_2,578ms	_2,608ms	_{p=0.298 n=6}
_{Req 2 - geterr}	_{1,698ms (± 2.40%)}	_{1,688ms (± 2.64%)}	_~	_1,642ms	_1,744ms	_{p=0.748 n=6}
_{Req 3 - references}	_{117ms (± 7.53%)}	_{115ms (± 8.69%)}	_~	_106ms	_126ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{361ms (± 1.35%)}	_{360ms (± 0.29%)}	_~	_358ms	_361ms	_{p=0.867 n=6}
_{Req 5 - completionInfo count}	_{2,073 (± 0.00%)}	_{2,073 (± 0.00%)}	_~	_2,073	_2,073	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{312ms (± 1.54%)}	_{306ms (± 2.49%)}	_~	_297ms	_315ms	_{p=0.126 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{152.57ms (± 0.18%)}	_{152.66ms (± 0.22%)}	_{+0.09ms (+ 0.06%)}	_151.45ms	_157.63ms	_{p=0.013 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{227.68ms (± 0.17%)}	_{227.54ms (± 0.15%)}	_{-0.14ms (- 0.06%)}	_226.02ms	_231.06ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.93ms (± 0.17%)}	_{228.97ms (± 0.23%)}	_~	_227.35ms	_245.58ms	_{p=0.691 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.89ms (± 0.16%)}	_{228.76ms (± 0.16%)}	_{-0.12ms (- 0.05%)}	_227.41ms	_234.78ms	_{p=0.003 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2023-10-24T17:37:22Z

Hey @RyanCavanaugh, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2023-10-24T17:44:28Z

@RyanCavanaugh Here are the results of running the top-repos suite comparing main and refs/pull/56201/merge:

Everything looks good!

typescript-bot · 2023-10-24T18:41:53Z

@RyanCavanaugh Here are the results of running the top-repos suite comparing main and refs/pull/56201/merge:

Everything looks good!

julienandreu · 2023-12-27T03:44:05Z

tests/cases/compiler/contextualPropertyOfGenericFilteringMappedType.ts

+
+declare function f2<T extends object>(
+  data: T,
+  handlers: { [P in keyof T as T[P] extends string ? P : never]: (value: T[P], prop: P) => void },


Question: Is there any reason you're using the extends string here instead of extends PropertyKey ?

it's meant to actually filter something, so I intentionally filter T[P] that match some subset of potential types. Note that I'm checking against T[P] and not just P - but even if the check would be against P, I could still want to filter the keys so PropertyKey isn't what I'd use here

…ontextual-filtering-mapped-type

jakebailey · 2024-08-08T16:26:33Z

This also makes me wonder if this is also a bug:

- const keysRemapped = !!target.declaration.nameType;
+ const keysRemapped = getMappedTypeNameTypeKind(target) === MappedTypeNameTypeKind.Remapping;

(Or maybe other places where nameType is used)

Fixed types of properties of contextual filtering mapped types

546f5d7

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Oct 24, 2023

sandersn requested review from andrewbranch and rbuckton November 2, 2023 22:24

sandersn assigned rbuckton Nov 2, 2023

julienandreu reviewed Dec 27, 2023

View reviewed changes

Merge remote-tracking branch 'origin/main' into fix/type-of-prop-of-c…

0c09bc0

…ontextual-filtering-mapped-type

typescript-bot added For Backlog Bug PRs that fix a backlog bug and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Aug 7, 2024

andrewbranch approved these changes Aug 8, 2024

View reviewed changes

andrewbranch merged commit 3cf708e into microsoft:main Aug 8, 2024
32 checks passed

Andarist deleted the fix/type-of-prop-of-contextual-filtering-mapped-type branch August 8, 2024 16:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed types of properties of contextual filtering mapped types #56201

Fixed types of properties of contextual filtering mapped types #56201

Andarist commented Oct 24, 2023 •

edited

Loading

typescript-bot commented Oct 24, 2023

RyanCavanaugh commented Oct 24, 2023

typescript-bot commented Oct 24, 2023 •

edited

Loading

typescript-bot commented Oct 24, 2023 •

edited

Loading

typescript-bot commented Oct 24, 2023 •

edited

Loading

typescript-bot commented Oct 24, 2023 •

edited

Loading

typescript-bot commented Oct 24, 2023 •

edited

Loading

typescript-bot commented Oct 24, 2023 •

edited

Loading

typescript-bot commented Oct 24, 2023 •

edited

Loading

typescript-bot commented Oct 24, 2023 •

edited

Loading

typescript-bot commented Oct 24, 2023

typescript-bot commented Oct 24, 2023

typescript-bot commented Oct 24, 2023

Compiler

tsserver

Startup

typescript-bot commented Oct 24, 2023

typescript-bot commented Oct 24, 2023

typescript-bot commented Oct 24, 2023

julienandreu Dec 27, 2023 •

edited

Loading

Andarist Aug 7, 2024

jakebailey commented Aug 8, 2024

Fixed types of properties of contextual filtering mapped types #56201

Fixed types of properties of contextual filtering mapped types #56201

Conversation

Andarist commented Oct 24, 2023 • edited Loading

typescript-bot commented Oct 24, 2023

RyanCavanaugh commented Oct 24, 2023

typescript-bot commented Oct 24, 2023 • edited Loading

typescript-bot commented Oct 24, 2023 • edited Loading

typescript-bot commented Oct 24, 2023 • edited Loading

typescript-bot commented Oct 24, 2023 • edited Loading

typescript-bot commented Oct 24, 2023 • edited Loading

typescript-bot commented Oct 24, 2023 • edited Loading

typescript-bot commented Oct 24, 2023 • edited Loading

typescript-bot commented Oct 24, 2023 • edited Loading

typescript-bot commented Oct 24, 2023

typescript-bot commented Oct 24, 2023

typescript-bot commented Oct 24, 2023

Compiler

tsserver

Startup

typescript-bot commented Oct 24, 2023

typescript-bot commented Oct 24, 2023

typescript-bot commented Oct 24, 2023

julienandreu Dec 27, 2023 • edited Loading

Choose a reason for hiding this comment

Andarist Aug 7, 2024

Choose a reason for hiding this comment

jakebailey commented Aug 8, 2024

Andarist commented Oct 24, 2023 •

edited

Loading

typescript-bot commented Oct 24, 2023 •

edited

Loading

typescript-bot commented Oct 24, 2023 •

edited

Loading

typescript-bot commented Oct 24, 2023 •

edited

Loading

typescript-bot commented Oct 24, 2023 •

edited

Loading

typescript-bot commented Oct 24, 2023 •

edited

Loading

typescript-bot commented Oct 24, 2023 •

edited

Loading

typescript-bot commented Oct 24, 2023 •

edited

Loading

typescript-bot commented Oct 24, 2023 •

edited

Loading

julienandreu Dec 27, 2023 •

edited

Loading