Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow object prototype property access on const enums #55424

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Disallow object prototype property access on const enums #55424

merged 1 commit into from
Aug 29, 2023

Conversation

Andarist
Copy link
Contributor

fixes #55421

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Aug 17, 2023
@jakebailey
Copy link
Member

oh this one's interesting

@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this faster

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 17, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the tsc-only perf test suite on this PR at 2ab21a8. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 17, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 2ab21a8. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 17, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 2ab21a8. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 17, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 2ab21a8. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Angular - node (v16.17.1, x64)
Memory used 300,372k (± 0.00%) 300,375k (± 0.01%) ~ 300,359k 300,416k p=0.936 n=6
Parse Time 3.03s (± 0.17%) 3.02s (± 0.46%) ~ 3.01s 3.05s p=0.437 n=6
Bind Time 0.93s (± 0.00%) 0.93s (± 0.00%) ~ 0.93s 0.93s p=1.000 n=6
Check Time 9.49s (± 0.24%) 9.51s (± 0.22%) ~ 9.47s 9.53s p=0.195 n=6
Emit Time 7.63s (± 0.15%) 7.64s (± 0.53%) ~ 7.58s 7.68s p=0.686 n=6
Total Time 21.07s (± 0.15%) 21.10s (± 0.19%) ~ 21.05s 21.15s p=0.147 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 193,884k (± 0.01%) 193,873k (± 0.02%) ~ 193,794k 193,919k p=0.873 n=6
Parse Time 1.57s (± 1.09%) 1.57s (± 1.09%) ~ 1.55s 1.59s p=1.000 n=6
Bind Time 0.79s (± 0.00%) 0.79s (± 0.00%) ~ 0.79s 0.79s p=1.000 n=6
Check Time 9.93s (± 0.26%) 9.94s (± 0.32%) ~ 9.90s 9.98s p=0.565 n=6
Emit Time 2.74s (± 0.15%) 2.74s (± 0.19%) ~ 2.73s 2.74s p=0.595 n=6
Total Time 15.03s (± 0.28%) 15.04s (± 0.12%) ~ 15.01s 15.06s p=0.936 n=6
Monaco - node (v16.17.1, x64)
Memory used 347,112k (± 0.01%) 347,101k (± 0.01%) ~ 347,050k 347,121k p=0.148 n=6
Parse Time 2.68s (± 0.15%) 2.69s (± 0.19%) ~ 2.68s 2.69s p=0.112 n=6
Bind Time 0.99s (± 0.00%) 0.99s (± 0.00%) ~ 0.99s 0.99s p=1.000 n=6
Check Time 7.91s (± 0.22%) 7.93s (± 0.31%) ~ 7.90s 7.96s p=0.104 n=6
Emit Time 4.25s (± 0.27%) 4.25s (± 0.28%) ~ 4.24s 4.27s p=0.933 n=6
Total Time 15.83s (± 0.13%) 15.86s (± 0.17%) ~ 15.82s 15.89s p=0.106 n=6
TFS - node (v16.17.1, x64)
Memory used 301,127k (± 0.00%) 301,138k (± 0.01%) ~ 301,109k 301,156k p=0.229 n=6
Parse Time 2.17s (± 0.69%) 2.17s (± 0.61%) ~ 2.15s 2.18s p=0.788 n=6
Bind Time 1.11s (± 0.37%) 1.11s (± 0.74%) ~ 1.09s 1.11s p=0.218 n=6
Check Time 7.24s (± 0.34%) 7.25s (± 0.49%) ~ 7.22s 7.31s p=0.936 n=6
Emit Time 3.96s (± 0.25%) 3.98s (± 0.25%) +0.02s (+ 0.42%) 3.97s 3.99s p=0.026 n=6
Total Time 14.48s (± 0.18%) 14.51s (± 0.26%) ~ 14.46s 14.56s p=0.373 n=6
material-ui - node (v16.17.1, x64)
Memory used 479,454k (± 0.02%) 479,462k (± 0.01%) ~ 479,371k 479,528k p=0.689 n=6
Parse Time 3.15s (± 0.31%) 3.15s (± 0.26%) ~ 3.15s 3.17s p=0.340 n=6
Bind Time 0.91s (± 0.00%) 0.91s (± 0.00%) ~ 0.91s 0.91s p=1.000 n=6
Check Time 17.94s (± 0.32%) 17.90s (± 0.39%) ~ 17.83s 18.01s p=0.422 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.00s (± 0.30%) 21.97s (± 0.33%) ~ 21.90s 22.07s p=0.574 n=6
xstate - node (v16.17.1, x64)
Memory used 542,856k (± 0.02%) 542,794k (± 0.01%) ~ 542,700k 542,904k p=0.471 n=6
Parse Time 3.70s (± 0.14%) 3.70s (± 0.14%) ~ 3.69s 3.70s p=1.000 n=6
Bind Time 1.42s (± 4.47%) 1.36s (± 3.38%) ~ 1.33s 1.45s p=0.153 n=6
Check Time 3.23s (± 3.11%) 3.31s (± 1.61%) ~ 3.22s 3.36s p=0.148 n=6
Emit Time 0.08s (± 0.00%) 0.08s (± 4.99%) ~ 0.08s 0.09s p=0.405 n=6
Total Time 8.43s (± 0.53%) 8.44s (± 0.32%) ~ 8.40s 8.48s p=0.375 n=6
System info unknown
Hosts
  • node (v16.17.1, x64)
Scenarios
  • Angular - node (v16.17.1, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Monaco - node (v16.17.1, x64)
  • TFS - node (v16.17.1, x64)
  • material-ui - node (v16.17.1, x64)
  • xstate - node (v16.17.1, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/55424/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Unknown failure"
  • 1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

  • [NEW] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
    • /home/vsts/work/1/s/typescript-55424/lib/lib.es2015.collection.d.ts(62,11)
    • /home/vsts/work/1/s/typescript-55424/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-55424/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-55424/lib/lib.es2015.collection.d.ts(62,11)
    • /home/vsts/work/1/s/typescript-55424/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-55424/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-55424/lib/lib.es2015.collection.d.ts(62,11)
    • /home/vsts/work/1/s/typescript-55424/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-55424/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-55424/lib/lib.es2015.collection.d.ts(62,11)
    • /home/vsts/work/1/s/typescript-55424/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-55424/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-55424/lib/lib.es2015.collection.d.ts(62,11)
    • /home/vsts/work/1/s/typescript-55424/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-55424/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
  • [MISSING] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(62,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(62,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(62,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(62,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(62,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/55424/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

Hey @jakebailey, it looks like the DT test run failed. Please check the log for more details.
You can check the log here.

@jakebailey jakebailey merged commit 9f9a72a into microsoft:main Aug 29, 2023
19 checks passed
snovader pushed a commit to mestro-se/TypeScript that referenced this pull request Sep 23, 2023
@Andarist @snovader
Disallow object prototype property access on const enums (microsoft#5…
19d8762 
…5424)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey jakebailey approved these changes

@iisaduan iisaduan Awaiting requested review from iisaduan

Assignees

@jakebailey jakebailey

Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Object properties are allowed on const enums
3 participants
@Andarist @jakebailey @typescript-bot