Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Caching resolutions in buildInfo and reusing them #50007

Draft
wants to merge 31 commits into
base: main
Choose a base branch
from
Draft

[WIP] Caching resolutions in buildInfo and reusing them #50007

wants to merge 31 commits into from

Commits on Dec 9, 2022

  1. Add new option to cacheResolution (No actual functionality yet)

    @sheetalkamat
    sheetalkamat committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    3172629 View commit details
    Browse the repository at this point in the history

  2. Add baselining of modules and type refs

    @sheetalkamat
    sheetalkamat committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    e1600ab View commit details
    Browse the repository at this point in the history

  3. Add tests

    @sheetalkamat
    sheetalkamat committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    666eece View commit details
    Browse the repository at this point in the history

  4. Store resolved module and type reference resolution cache in buildinfo

    @sheetalkamat
    sheetalkamat committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    1eeea26 View commit details
    Browse the repository at this point in the history

  5. Read reusable module cache information from the buildinfo

    @sheetalkamat
    sheetalkamat committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    76100d7 View commit details
    Browse the repository at this point in the history

  6. Add reusing cache stub

    @sheetalkamat
    sheetalkamat committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    4bc74b9 View commit details
    Browse the repository at this point in the history

  7. Buildinfo resolutions actually reused

    @sheetalkamat
    sheetalkamat committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    23cfc79 View commit details
    Browse the repository at this point in the history

  8. Handle project reference redirects for the module and type reference … 

    …resolutions
    @sheetalkamat
    sheetalkamat committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    0132dc0 View commit details
    Browse the repository at this point in the history

  9. Test for module resolutions from different directories

    @sheetalkamat
    sheetalkamat committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    d55ab98 View commit details
    Browse the repository at this point in the history

  10. Handle resolutions that would be same in ancestor directory and can b… 

    …e derived through ancestor map
    @sheetalkamat
    sheetalkamat committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    ce07d0e View commit details
    Browse the repository at this point in the history

  11. Do not store failed lookups with cacheResolution option if it is reso… 

    …lved to a file since they do not matter
    @sheetalkamat
    sheetalkamat committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    959206d View commit details
    Browse the repository at this point in the history

  12. Add tests where module resolution caches should reuse the resolutions… 

    … from buildInfo
    @sheetalkamat
    sheetalkamat committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    0446430 View commit details
    Browse the repository at this point in the history

  13. Reusing resolutions in tsserver scenario

    @sheetalkamat
    sheetalkamat committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    207226a View commit details
    Browse the repository at this point in the history

  14. Set old program build info as a location to look for from module reso… 

    …lution caches
    @sheetalkamat
    sheetalkamat committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    591960e View commit details
    Browse the repository at this point in the history

  15. Modify resolution cache to update on program creation completion

    @sheetalkamat
    sheetalkamat committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    71ebed9 View commit details
    Browse the repository at this point in the history

  16. Remove files that are not in program from cache of unresolved imports

    @sheetalkamat
    sheetalkamat committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    4d127fa View commit details
    Browse the repository at this point in the history

  17. Tests for unresolved imports from multiple places

    @sheetalkamat
    sheetalkamat committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    feb3220 View commit details
    Browse the repository at this point in the history

  18. More tests for cache reuse directory structure

    @sheetalkamat
    sheetalkamat committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    84cda33 View commit details
    Browse the repository at this point in the history

  19. Start using cache as perDirectory lookup

    @sheetalkamat
    sheetalkamat committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    2219b5d View commit details
    Browse the repository at this point in the history

  20. Add tests where cache resoluition is incorrectly used because of not … 

    …checking affected locations
    @sheetalkamat
    sheetalkamat committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    6261b6c View commit details
    Browse the repository at this point in the history

  21. Store package json hash in buildinfo

    @sheetalkamat
    sheetalkamat committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    e1ed9ea View commit details
    Browse the repository at this point in the history

  22. Use the hashes to verify the affecting location before using the reso… 

    …lution
    @sheetalkamat
    sheetalkamat committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    7de4780 View commit details
    Browse the repository at this point in the history

  23. Add tests for package json edits

    @sheetalkamat
    sheetalkamat committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    5c11252 View commit details
    Browse the repository at this point in the history

  24. Store package.json for the directories in buildinfo

    @sheetalkamat
    sheetalkamat committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    e21738c View commit details
    Browse the repository at this point in the history

  25. During cacheResolutions dont watch failed lookups and dont look at th… 

    …ose package.json if one exists per buildInfo
    @sheetalkamat
    sheetalkamat committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    be5ecb2 View commit details
    Browse the repository at this point in the history

  26. Dont store package json path if its found in same directory

    @sheetalkamat
    sheetalkamat committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    78e215f View commit details
    Browse the repository at this point in the history

  27. Cache packagejson scopes per directory

    @sheetalkamat
    sheetalkamat committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    1e123ec View commit details
    Browse the repository at this point in the history

  28. Dont store isExternalLibraryImport in the buildInfo

    @sheetalkamat
    sheetalkamat committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    81a1af9 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2022

  1. Store resolvedFileName as fileId instead of structure if thats the on… 

    …ly info in resolution
    @sheetalkamat
    sheetalkamat committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    3115572 View commit details
    Browse the repository at this point in the history

  2. Always respect preserveSymlinks

    @sheetalkamat
    sheetalkamat committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    2bb56da View commit details
    Browse the repository at this point in the history

  3. Dont store originalPath as separate, instead store originalPath || re… 

    …solvedFileName and resolve the symlinks on read
    @sheetalkamat
    sheetalkamat committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    b179c7c View commit details
    Browse the repository at this point in the history