Generate a unique type parameter name for each nested type parameter #31544
Conversation
|
Will this also fix #30373? It looks similar to the other issue. |
|
Quite possibly. Quickinfo does use the same machinery for printing types. |
weswigham
force-pushed
the
revise-type-param-namegen
branch
from
0831876
to
6aa8ea4
Compare
|
@typescript-bot test this |
|
Heya @weswigham, I've started to run the extended test suite on this PR at 6aa8ea4. You can monitor the build here. It should now contribute to this PR's status checks. |
|
Heya @weswigham, I've started to run the community code test suite on this PR at 6aa8ea4. You can monitor the build here. It should now contribute to this PR's status checks. |
|
Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at 6aa8ea4. You can monitor the build here. It should now contribute to this PR's status checks. |
|
RWC changes are minor - we now use some |
|
DT failure is unrelated (a module seems to have gone missing from DT), so looks good. |
|
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
|
User suite failure is just a new package in the |
tests/baselines/reference/declarationsWithRecursiveInternalTypesProduceUniqueTypeParams.js
Outdated
Show resolved
Hide resolved
Previously we'd generate a name for each declaration we saw, but this neglected to account of the possibility that we see multiple unique instantiations of the same symbol. Now the name is generated in the node builder, rather than deferring to the emitter, so we can have a unique name for each type.
Fixes half of the issues brought to light by #30732.
Fixes #31605.