Preserve comments on elided import declarations #27407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @rbuckton do you think this approach is reasonable? |
| @@ -129,6 +129,8 @@ define(["require", "exports"], function (require, exports) { | |||
| define(["require", "exports", "commentsExternalModules_0"], function (require, exports, extMod) { | |||
| "use strict"; | |||
| Object.defineProperty(exports, "__esModule", { value: true }); | |||
| /**This is on import declaration*/ | |||
There was a problem hiding this comment.
This doesn't look right.. This jsdoc comment is associated with import declaration and without it (and missing trailing comments followed by another declaration) could make these associated with that declaration...
sandersn
added
For Backlog Bug
|
This PR hasn't seen any activity for quite a while, so I'm going to close it to keep the number of open PRs manageable. Feel free to open a fresh PR or restart the discussion here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26079