Add new option "noUncheckedSideEffectImports" (#58941)

microsoft · Jul 20, 2024 · 85d6bb6 · 85d6bb6
1 parent 79bd844
commit 85d6bb6
Show file tree

Hide file tree

Showing 78 changed files with 985 additions and 1 deletion.
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -720,6 +720,7 @@ import {
     isSetAccessorDeclaration,
     isShorthandAmbientModuleSymbol,
     isShorthandPropertyAssignment,
+    isSideEffectImport,
     isSingleOrDoubleQuote,
     isSourceFile,
     isSourceFileJS,
@@ -1505,6 +1506,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
     var noImplicitThis = getStrictOptionValue(compilerOptions, "noImplicitThis");
     var useUnknownInCatchVariables = getStrictOptionValue(compilerOptions, "useUnknownInCatchVariables");
     var exactOptionalPropertyTypes = compilerOptions.exactOptionalPropertyTypes;
+    var noUncheckedSideEffectImports = !!compilerOptions.noUncheckedSideEffectImports;
 
     var checkBinaryExpression = createCheckBinaryExpression();
     var emitResolver = createResolver();
@@ -4660,7 +4662,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
                 // merged symbol is module declaration symbol combined with all augmentations
                 return getMergedSymbol(sourceFile.symbol);
             }
-            if (errorNode && moduleNotFoundError) {
+            if (errorNode && moduleNotFoundError && !isSideEffectImport(errorNode)) {
                 // report errors only if it was requested
                 error(errorNode, Diagnostics.File_0_is_not_a_module, sourceFile.fileName);
             }
@@ -4765,6 +4767,10 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
     }
 
     function errorOnImplicitAnyModule(isError: boolean, errorNode: Node, sourceFile: SourceFile, mode: ResolutionMode, { packageId, resolvedFileName }: ResolvedModuleFull, moduleReference: string): void {
+        if (isSideEffectImport(errorNode)) {
+            return;
+        }
+
         let errorInfo: DiagnosticMessageChain | undefined;
         if (!isExternalModuleNameRelative(moduleReference) && packageId) {
             errorInfo = createModuleNotFoundChain(sourceFile, host, moduleReference, mode, packageId.name);
@@ -47246,6 +47252,9 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
                     }
                 }
             }
+            else if (noUncheckedSideEffectImports && !importClause) {
+                void resolveExternalModuleName(node, node.moduleSpecifier);
+            }
         }
         checkImportAttributes(node);
     }

diff --git a/src/compiler/commandLineParser.ts b/src/compiler/commandLineParser.ts
@@ -1202,6 +1202,15 @@ const commandOptionsWithoutBuild: CommandLineOption[] = [
         category: Diagnostics.Modules,
         description: Diagnostics.Conditions_to_set_in_addition_to_the_resolver_specific_defaults_when_resolving_imports,
     },
+    {
+        name: "noUncheckedSideEffectImports",
+        type: "boolean",
+        affectsSemanticDiagnostics: true,
+        affectsBuildInfo: true,
+        category: Diagnostics.Modules,
+        description: Diagnostics.Check_side_effect_imports,
+        defaultValueDescription: false,
+    },
 
     // Source Maps
     {

diff --git a/src/compiler/diagnosticMessages.json b/src/compiler/diagnosticMessages.json
@@ -6388,6 +6388,10 @@
         "category": "Message",
         "code": 6805
     },
+    "Check side effect imports.": {
+        "category": "Message",
+        "code": 6806
+    },
 
     "one of:": {
         "category": "Message",

diff --git a/src/compiler/types.ts b/src/compiler/types.ts
@@ -7418,6 +7418,7 @@ export interface CompilerOptions {
     target?: ScriptTarget;
     traceResolution?: boolean;
     useUnknownInCatchVariables?: boolean;
+    noUncheckedSideEffectImports?: boolean;
     resolveJsonModule?: boolean;
     types?: string[];
     /** Paths used to compute primary types search locations */

diff --git a/src/compiler/utilities.ts b/src/compiler/utilities.ts
@@ -287,6 +287,7 @@ import {
     isIdentifier,
     isIdentifierStart,
     isIdentifierText,
+    isImportDeclaration,
     isImportTypeNode,
     isInterfaceDeclaration,
     isJSDoc,
@@ -11758,3 +11759,9 @@ export function hasInferredType(node: Node): node is HasInferredType {
             return false;
     }
 }
+
+/** @internal */
+export function isSideEffectImport(node: Node): boolean {
+    const ancestor = findAncestor(node, isImportDeclaration);
+    return !!ancestor && !ancestor.importClause;
+}
diff --git a/src/testRunner/unittests/tscWatch/programUpdates.ts b/src/testRunner/unittests/tscWatch/programUpdates.ts
@@ -2245,4 +2245,40 @@ import { x } from "../b";`,
             },
         ],
     });
+
+    verifyTscWatch({
+        scenario,
+        subScenario: "when changing noUncheckedSideEffectImports of config file",
+        commandLineArgs: ["-w", "-p", ".", "--extendedDiagnostics"],
+        sys: () => {
+            const module1: File = {
+                path: `/user/username/projects/myproject/a.ts`,
+                content: `import "does-not-exist";`,
+            };
+            const config: File = {
+                path: `/user/username/projects/myproject/tsconfig.json`,
+                content: jsonToReadableText({
+                    compilerOptions: {
+                        noUncheckedSideEffectImports: false,
+                    },
+                }),
+            };
+            return createWatchedSystem([module1, config, libFile], { currentDirectory: "/user/username/projects/myproject" });
+        },
+        edits: [
+            {
+                caption: "Change noUncheckedSideEffectImports to true",
+                edit: sys =>
+                    sys.writeFile(
+                        `/user/username/projects/myproject/tsconfig.json`,
+                        jsonToReadableText({
+                            compilerOptions: {
+                                noUncheckedSideEffectImports: true,
+                            },
+                        }),
+                    ),
+                timeouts: sys => sys.runQueuedTimeoutCallbacks(),
+            },
+        ],
+    });
 });
diff --git a/tests/baselines/reference/api/typescript.d.ts b/tests/baselines/reference/api/typescript.d.ts
@@ -7017,6 +7017,7 @@ declare namespace ts {
         target?: ScriptTarget;
         traceResolution?: boolean;
         useUnknownInCatchVariables?: boolean;
+        noUncheckedSideEffectImports?: boolean;
         resolveJsonModule?: boolean;
         types?: string[];
         /** Paths used to compute primary types search locations */

diff --git a/tests/baselines/reference/config/initTSConfig/Default initialized TSConfig/tsconfig.json b/tests/baselines/reference/config/initTSConfig/Default initialized TSConfig/tsconfig.json
@@ -39,6 +39,7 @@
     // "resolvePackageJsonExports": true,                /* Use the package.json 'exports' field when resolving package imports. */
     // "resolvePackageJsonImports": true,                /* Use the package.json 'imports' field when resolving imports. */
     // "customConditions": [],                           /* Conditions to set in addition to the resolver-specific defaults when resolving imports. */
+    // "noUncheckedSideEffectImports": true,             /* Check side effect imports. */
     // "resolveJsonModule": true,                        /* Enable importing .json files. */
     // "allowArbitraryExtensions": true,                 /* Enable importing files with any extension, provided a declaration file is present. */
     // "noResolve": true,                                /* Disallow 'import's, 'require's or '<reference>'s from expanding the number of files TypeScript should add to a project. */

diff --git a/tests/baselines/reference/config/initTSConfig/Initialized TSConfig with --help/tsconfig.json b/tests/baselines/reference/config/initTSConfig/Initialized TSConfig with --help/tsconfig.json
@@ -39,6 +39,7 @@
     // "resolvePackageJsonExports": true,                /* Use the package.json 'exports' field when resolving package imports. */
     // "resolvePackageJsonImports": true,                /* Use the package.json 'imports' field when resolving imports. */
     // "customConditions": [],                           /* Conditions to set in addition to the resolver-specific defaults when resolving imports. */
+    // "noUncheckedSideEffectImports": true,             /* Check side effect imports. */
     // "resolveJsonModule": true,                        /* Enable importing .json files. */
     // "allowArbitraryExtensions": true,                 /* Enable importing files with any extension, provided a declaration file is present. */
     // "noResolve": true,                                /* Disallow 'import's, 'require's or '<reference>'s from expanding the number of files TypeScript should add to a project. */

diff --git a/...s/baselines/reference/config/initTSConfig/Initialized TSConfig with --watch/tsconfig.json b/...s/baselines/reference/config/initTSConfig/Initialized TSConfig with --watch/tsconfig.json
@@ -39,6 +39,7 @@
     // "resolvePackageJsonExports": true,                /* Use the package.json 'exports' field when resolving package imports. */
     // "resolvePackageJsonImports": true,                /* Use the package.json 'imports' field when resolving imports. */
     // "customConditions": [],                           /* Conditions to set in addition to the resolver-specific defaults when resolving imports. */
+    // "noUncheckedSideEffectImports": true,             /* Check side effect imports. */
     // "resolveJsonModule": true,                        /* Enable importing .json files. */
     // "allowArbitraryExtensions": true,                 /* Enable importing files with any extension, provided a declaration file is present. */
     // "noResolve": true,                                /* Disallow 'import's, 'require's or '<reference>'s from expanding the number of files TypeScript should add to a project. */

diff --git a/...es/reference/config/initTSConfig/Initialized TSConfig with advanced options/tsconfig.json b/...es/reference/config/initTSConfig/Initialized TSConfig with advanced options/tsconfig.json
@@ -39,6 +39,7 @@
     // "resolvePackageJsonExports": true,                /* Use the package.json 'exports' field when resolving package imports. */
     // "resolvePackageJsonImports": true,                /* Use the package.json 'imports' field when resolving imports. */
     // "customConditions": [],                           /* Conditions to set in addition to the resolver-specific defaults when resolving imports. */
+    // "noUncheckedSideEffectImports": true,             /* Check side effect imports. */
     // "resolveJsonModule": true,                        /* Enable importing .json files. */
     // "allowArbitraryExtensions": true,                 /* Enable importing files with any extension, provided a declaration file is present. */
     // "noResolve": true,                                /* Disallow 'import's, 'require's or '<reference>'s from expanding the number of files TypeScript should add to a project. */

diff --git a/...onfig/initTSConfig/Initialized TSConfig with boolean value compiler options/tsconfig.json b/...onfig/initTSConfig/Initialized TSConfig with boolean value compiler options/tsconfig.json
@@ -39,6 +39,7 @@
     // "resolvePackageJsonExports": true,                /* Use the package.json 'exports' field when resolving package imports. */
     // "resolvePackageJsonImports": true,                /* Use the package.json 'imports' field when resolving imports. */
     // "customConditions": [],                           /* Conditions to set in addition to the resolver-specific defaults when resolving imports. */
+    // "noUncheckedSideEffectImports": true,             /* Check side effect imports. */
     // "resolveJsonModule": true,                        /* Enable importing .json files. */
     // "allowArbitraryExtensions": true,                 /* Enable importing files with any extension, provided a declaration file is present. */
     // "noResolve": true,                                /* Disallow 'import's, 'require's or '<reference>'s from expanding the number of files TypeScript should add to a project. */

diff --git a/...e/config/initTSConfig/Initialized TSConfig with enum value compiler options/tsconfig.json b/...e/config/initTSConfig/Initialized TSConfig with enum value compiler options/tsconfig.json
@@ -39,6 +39,7 @@
     // "resolvePackageJsonExports": true,                /* Use the package.json 'exports' field when resolving package imports. */
     // "resolvePackageJsonImports": true,                /* Use the package.json 'imports' field when resolving imports. */
     // "customConditions": [],                           /* Conditions to set in addition to the resolver-specific defaults when resolving imports. */
+    // "noUncheckedSideEffectImports": true,             /* Check side effect imports. */
     // "resolveJsonModule": true,                        /* Enable importing .json files. */
     // "allowArbitraryExtensions": true,                 /* Enable importing files with any extension, provided a declaration file is present. */
     // "noResolve": true,                                /* Disallow 'import's, 'require's or '<reference>'s from expanding the number of files TypeScript should add to a project. */

diff --git a/...lines/reference/config/initTSConfig/Initialized TSConfig with files options/tsconfig.json b/...lines/reference/config/initTSConfig/Initialized TSConfig with files options/tsconfig.json
@@ -39,6 +39,7 @@
     // "resolvePackageJsonExports": true,                /* Use the package.json 'exports' field when resolving package imports. */
     // "resolvePackageJsonImports": true,                /* Use the package.json 'imports' field when resolving imports. */
     // "customConditions": [],                           /* Conditions to set in addition to the resolver-specific defaults when resolving imports. */
+    // "noUncheckedSideEffectImports": true,             /* Check side effect imports. */
     // "resolveJsonModule": true,                        /* Enable importing .json files. */
     // "allowArbitraryExtensions": true,                 /* Enable importing files with any extension, provided a declaration file is present. */
     // "noResolve": true,                                /* Disallow 'import's, 'require's or '<reference>'s from expanding the number of files TypeScript should add to a project. */

diff --git a/...nfig/initTSConfig/Initialized TSConfig with incorrect compiler option value/tsconfig.json b/...nfig/initTSConfig/Initialized TSConfig with incorrect compiler option value/tsconfig.json
@@ -39,6 +39,7 @@
     // "resolvePackageJsonExports": true,                /* Use the package.json 'exports' field when resolving package imports. */
     // "resolvePackageJsonImports": true,                /* Use the package.json 'imports' field when resolving imports. */
     // "customConditions": [],                           /* Conditions to set in addition to the resolver-specific defaults when resolving imports. */
+    // "noUncheckedSideEffectImports": true,             /* Check side effect imports. */
     // "resolveJsonModule": true,                        /* Enable importing .json files. */
     // "allowArbitraryExtensions": true,                 /* Enable importing files with any extension, provided a declaration file is present. */
     // "noResolve": true,                                /* Disallow 'import's, 'require's or '<reference>'s from expanding the number of files TypeScript should add to a project. */

diff --git a/...nce/config/initTSConfig/Initialized TSConfig with incorrect compiler option/tsconfig.json b/...nce/config/initTSConfig/Initialized TSConfig with incorrect compiler option/tsconfig.json
@@ -39,6 +39,7 @@
     // "resolvePackageJsonExports": true,                /* Use the package.json 'exports' field when resolving package imports. */
     // "resolvePackageJsonImports": true,                /* Use the package.json 'imports' field when resolving imports. */
     // "customConditions": [],                           /* Conditions to set in addition to the resolver-specific defaults when resolving imports. */
+    // "noUncheckedSideEffectImports": true,             /* Check side effect imports. */
     // "resolveJsonModule": true,                        /* Enable importing .json files. */
     // "allowArbitraryExtensions": true,                 /* Enable importing files with any extension, provided a declaration file is present. */
     // "noResolve": true,                                /* Disallow 'import's, 'require's or '<reference>'s from expanding the number of files TypeScript should add to a project. */

diff --git a/...nitTSConfig/Initialized TSConfig with list compiler options with enum value/tsconfig.json b/...nitTSConfig/Initialized TSConfig with list compiler options with enum value/tsconfig.json
@@ -39,6 +39,7 @@
     // "resolvePackageJsonExports": true,                /* Use the package.json 'exports' field when resolving package imports. */
     // "resolvePackageJsonImports": true,                /* Use the package.json 'imports' field when resolving imports. */
     // "customConditions": [],                           /* Conditions to set in addition to the resolver-specific defaults when resolving imports. */
+    // "noUncheckedSideEffectImports": true,             /* Check side effect imports. */
     // "resolveJsonModule": true,                        /* Enable importing .json files. */
     // "allowArbitraryExtensions": true,                 /* Enable importing files with any extension, provided a declaration file is present. */
     // "noResolve": true,                                /* Disallow 'import's, 'require's or '<reference>'s from expanding the number of files TypeScript should add to a project. */

diff --git a/...ference/config/initTSConfig/Initialized TSConfig with list compiler options/tsconfig.json b/...ference/config/initTSConfig/Initialized TSConfig with list compiler options/tsconfig.json
@@ -39,6 +39,7 @@
     // "resolvePackageJsonExports": true,                /* Use the package.json 'exports' field when resolving package imports. */
     // "resolvePackageJsonImports": true,                /* Use the package.json 'imports' field when resolving imports. */
     // "customConditions": [],                           /* Conditions to set in addition to the resolver-specific defaults when resolving imports. */
+    // "noUncheckedSideEffectImports": true,             /* Check side effect imports. */
     // "resolveJsonModule": true,                        /* Enable importing .json files. */
     // "allowArbitraryExtensions": true,                 /* Enable importing files with any extension, provided a declaration file is present. */
     // "noResolve": true,                                /* Disallow 'import's, 'require's or '<reference>'s from expanding the number of files TypeScript should add to a project. */

diff --git a/...ig/showConfig/Shows tsconfig for single option/noUncheckedSideEffectImports/tsconfig.json b/...ig/showConfig/Shows tsconfig for single option/noUncheckedSideEffectImports/tsconfig.json
@@ -0,0 +1,5 @@
+{
+    "compilerOptions": {
+        "noUncheckedSideEffectImports": true
+    }
+}
diff --git a/...lines/reference/sideEffectImports1(module=commonjs,nouncheckedsideeffectimports=false).js b/...lines/reference/sideEffectImports1(module=commonjs,nouncheckedsideeffectimports=false).js
@@ -0,0 +1,14 @@
+//// [tests/cases/compiler/sideEffectImports1.ts] ////
+
+//// [sideEffectImports1.ts]
+import "does-not-exist";
+import "./does-not-exist-either";
+import "./does-not-exist-either.js";
+
+
+//// [sideEffectImports1.js]
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+require("does-not-exist");
+require("./does-not-exist-either");
+require("./does-not-exist-either.js");
diff --git a/.../reference/sideEffectImports1(module=commonjs,nouncheckedsideeffectimports=false).symbols b/.../reference/sideEffectImports1(module=commonjs,nouncheckedsideeffectimports=false).symbols
@@ -0,0 +1,8 @@
+//// [tests/cases/compiler/sideEffectImports1.ts] ////
+
+=== sideEffectImports1.ts ===
+
+import "does-not-exist";
+import "./does-not-exist-either";
+import "./does-not-exist-either.js";
+
diff --git a/...es/reference/sideEffectImports1(module=commonjs,nouncheckedsideeffectimports=false).types b/...es/reference/sideEffectImports1(module=commonjs,nouncheckedsideeffectimports=false).types
@@ -0,0 +1,8 @@
+//// [tests/cases/compiler/sideEffectImports1.ts] ////
+
+=== sideEffectImports1.ts ===
+
+import "does-not-exist";
+import "./does-not-exist-either";
+import "./does-not-exist-either.js";
+
diff --git a/...eference/sideEffectImports1(module=commonjs,nouncheckedsideeffectimports=true).errors.txt b/...eference/sideEffectImports1(module=commonjs,nouncheckedsideeffectimports=true).errors.txt
@@ -0,0 +1,16 @@
+sideEffectImports1.ts(1,8): error TS2307: Cannot find module 'does-not-exist' or its corresponding type declarations.
+sideEffectImports1.ts(2,8): error TS2307: Cannot find module './does-not-exist-either' or its corresponding type declarations.
+sideEffectImports1.ts(3,8): error TS2307: Cannot find module './does-not-exist-either.js' or its corresponding type declarations.
+
+
+==== sideEffectImports1.ts (3 errors) ====
+    import "does-not-exist";
+           ~~~~~~~~~~~~~~~~
+!!! error TS2307: Cannot find module 'does-not-exist' or its corresponding type declarations.
+    import "./does-not-exist-either";
+           ~~~~~~~~~~~~~~~~~~~~~~~~~
+!!! error TS2307: Cannot find module './does-not-exist-either' or its corresponding type declarations.
+    import "./does-not-exist-either.js";
+           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+!!! error TS2307: Cannot find module './does-not-exist-either.js' or its corresponding type declarations.
+
diff --git a/...elines/reference/sideEffectImports1(module=commonjs,nouncheckedsideeffectimports=true).js b/...elines/reference/sideEffectImports1(module=commonjs,nouncheckedsideeffectimports=true).js
@@ -0,0 +1,14 @@
+//// [tests/cases/compiler/sideEffectImports1.ts] ////
+
+//// [sideEffectImports1.ts]
+import "does-not-exist";
+import "./does-not-exist-either";
+import "./does-not-exist-either.js";
+
+
+//// [sideEffectImports1.js]
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+require("does-not-exist");
+require("./does-not-exist-either");
+require("./does-not-exist-either.js");
diff --git a/...s/reference/sideEffectImports1(module=commonjs,nouncheckedsideeffectimports=true).symbols b/...s/reference/sideEffectImports1(module=commonjs,nouncheckedsideeffectimports=true).symbols
@@ -0,0 +1,8 @@
+//// [tests/cases/compiler/sideEffectImports1.ts] ////
+
+=== sideEffectImports1.ts ===
+
+import "does-not-exist";
+import "./does-not-exist-either";
+import "./does-not-exist-either.js";
+
diff --git a/...nes/reference/sideEffectImports1(module=commonjs,nouncheckedsideeffectimports=true).types b/...nes/reference/sideEffectImports1(module=commonjs,nouncheckedsideeffectimports=true).types
@@ -0,0 +1,8 @@
+//// [tests/cases/compiler/sideEffectImports1.ts] ////
+
+=== sideEffectImports1.ts ===
+
+import "does-not-exist";
+import "./does-not-exist-either";
+import "./does-not-exist-either.js";
+
diff --git a/...lines/reference/sideEffectImports1(module=nodenext,nouncheckedsideeffectimports=false).js b/...lines/reference/sideEffectImports1(module=nodenext,nouncheckedsideeffectimports=false).js
@@ -0,0 +1,14 @@
+//// [tests/cases/compiler/sideEffectImports1.ts] ////
+
+//// [sideEffectImports1.ts]
+import "does-not-exist";
+import "./does-not-exist-either";
+import "./does-not-exist-either.js";
+
+
+//// [sideEffectImports1.js]
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+require("does-not-exist");
+require("./does-not-exist-either");
+require("./does-not-exist-either.js");
diff --git a/.../reference/sideEffectImports1(module=nodenext,nouncheckedsideeffectimports=false).symbols b/.../reference/sideEffectImports1(module=nodenext,nouncheckedsideeffectimports=false).symbols
@@ -0,0 +1,8 @@
+//// [tests/cases/compiler/sideEffectImports1.ts] ////
+
+=== sideEffectImports1.ts ===
+
+import "does-not-exist";
+import "./does-not-exist-either";
+import "./does-not-exist-either.js";
+
diff --git a/...es/reference/sideEffectImports1(module=nodenext,nouncheckedsideeffectimports=false).types b/...es/reference/sideEffectImports1(module=nodenext,nouncheckedsideeffectimports=false).types
@@ -0,0 +1,8 @@
+//// [tests/cases/compiler/sideEffectImports1.ts] ////
+
+=== sideEffectImports1.ts ===
+
+import "does-not-exist";
+import "./does-not-exist-either";
+import "./does-not-exist-either.js";
+