Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding [Add]EventListenerOptions parameter for generated signatures #313

Merged
merged 2 commits into from
Oct 26, 2017
Merged

adding [Add]EventListenerOptions parameter for generated signatures #313

merged 2 commits into from
Oct 26, 2017

Commits on Oct 26, 2017

  1. adding [Add]EventListenerOptions parameter for generated signatures 

    For the signatures generated within TS.fsx:
* Changes the type of the third argument to `boolean | AddEventListenerOptions` for `addEventListener`
* Changes the type of the third argument to `boolean | EventListenerOptions` for `removeEventListener`

Additionally, there were a few changes in addedTypes.json that needed to be updated by adding `removeEventListener` signatures and updating both `addEventListener` and `removeEventListener` to allow options:
* BroadcastChannel
* IDBDatabase

microsoft/TypeScript#18136
    Adam J. Hines committed Oct 26, 2017
    Configuration menu
    Copy the full SHA
    c0cb9d9 View commit details
    Browse the repository at this point in the history

  2. adding this type to 'versionchange' event on IDBDatabase

    Adam J. Hines committed Oct 26, 2017
    Configuration menu
    Copy the full SHA
    0a2ebe8 View commit details
    Browse the repository at this point in the history