Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trace manipulation commands to Keysight PNA driver #6035

Merged
merged 5 commits into from
May 3, 2024

Conversation

spauka
Copy link
Contributor

@spauka spauka commented May 3, 2024

This PR adds trace manipulation commands to the Keysight PNA driver.

Specifically, we now allow the following interactions:

  • trace = pna.add_trace(): Create a new trace (of any number) on the PNA
  • trace = pna.enable_trace(trace_num): Enable and return the given trace number
  • trace.disable(): Disable a trace on the PNA

@spauka spauka marked this pull request as ready for review May 3, 2024 07:20
@spauka spauka requested a review from a team as a code owner May 3, 2024 07:20
Co-authored-by: Jens Hedegaard Nielsen <jenshnielsen@gmail.com>
Copy link

codecov bot commented May 3, 2024

Codecov Report

Attention: Patch coverage is 17.64706% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 67.50%. Comparing base (277675d) to head (6efabb5).
Report is 52 commits behind head on main.

Files Patch % Lines
src/qcodes/instrument_drivers/Keysight/N52xx.py 17.64% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6035      +/-   ##
==========================================
- Coverage   67.52%   67.50%   -0.03%     
==========================================
  Files         350      350              
  Lines       30301    30318      +17     
==========================================
+ Hits        20462    20465       +3     
- Misses       9839     9853      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenshnielsen jenshnielsen added this pull request to the merge queue May 3, 2024
Merged via the queue into microsoft:main with commit c125bea May 3, 2024
18 of 20 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants