get_component allow lookup from channeltuple/list #6009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6009 +/- ##
=======================================
Coverage 67.42% 67.42%
=======================================
Files 349 349
Lines 30201 30211 +10
=======================================
+ Hits 20364 20371 +7
- Misses 9837 9840 +3 ☔ View full report in Codecov by Sentry. |
jenshnielsen
force-pushed
the
lookup_component_from_channeltuple
branch
from
b668b13
to
c26b2e0
Compare
This enables a component to be looked up from a channellist/tuple by its full_name even if the component has not been added as an individual component but only as a member of a channeltuple/list.
jenshnielsen
force-pushed
the
lookup_component_from_channeltuple
branch
from
c26b2e0
to
0b53bcd
Compare
jenshnielsen
changed the title
astafan8
approved these changes
Apr 26, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable component to be looked up from a channeltuple in case it has only been added as such.