Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CryomagneticsModel4G Power Supply Driver #5968

Merged
merged 51 commits into from
May 3, 2024

Conversation

trevormorgan
Copy link
Contributor

@trevormorgan trevormorgan commented Apr 17, 2024

This Pull Request introduces the CryomagneticsModel4G

Summary of driver features:

  • Unit Conversion Handling: Implemented a reliable mechanism for unit conversions between kilogauss (kG) and tesla (T), ensuring precise magnetic field computations.
  • Parameter Management: Added comprehensive parameter support for magnetic field, ramp rates, and voltage readings, allowing detailed control and monitoring of the instrument.
  • Robust Error Detection: Enhanced the driver’s ability to detect and manage hardware-specific errors such as quench conditions and power failures, preventing operations under unsafe or unsuitable conditions.
  • Optimized magnet operating state checks to reduce command execution latency and system load.
  • Logging: Updated logging framework for clearer operational insights and enriched inline documentation for better code maintainability.

Testing:
Complemented the new features with a suite of unit tests, ensuring robustness and reliability through extensive coverage.

@trevormorgan trevormorgan requested a review from a team as a code owner April 17, 2024 00:05
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 75.29412% with 42 lines in your changes are missing coverage. Please review.

Project coverage is 67.57%. Comparing base (277675d) to head (b936f82).

Files Patch % Lines
...strument_drivers/cryomagnetics/_cryomagnetics4g.py 75.29% 42 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5968      +/-   ##
==========================================
+ Coverage   67.52%   67.57%   +0.04%     
==========================================
  Files         350      351       +1     
  Lines       30301    30471     +170     
==========================================
+ Hits        20462    20591     +129     
- Misses       9839     9880      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jenshnielsen jenshnielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trevormorgan

I left some comments inline. Please also make sure to add the CryoMagnetics folder to the docs. under docs/driver_api

@astafan8
Copy link
Contributor

@trevormorgan , and a news fragment would be great to add :) https://microsoft.github.io/Qcodes/community/contributing.html#pull-requests?highlight=newsfragments

@jenshnielsen jenshnielsen added this pull request to the merge queue May 3, 2024
Merged via the queue into microsoft:main with commit 9543b9e May 3, 2024
20 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants