Stahl driver fixes and improvements #5888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hp-peti
commented
Mar 25, 2024
hp-peti
commented
- extend regular expression to cover exponential notation in floating point response observed in real device
- allow TCP connection to socat'd serial port
- extend regular expression to cover exponential notation in floating point response observed in real device - allow TCP connection to socat'd serial port
|
@hp-peti Thanks for the contribution. Could you add a changelog entry to docs/changes/newsfragments/5888.improved_driver describing the change. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5888 +/- ##
==========================================
- Coverage 67.45% 66.44% -1.01%
==========================================
Files 348 348
Lines 30133 30138 +5
==========================================
- Hits 20326 20026 -300
- Misses 9807 10112 +305 ☔ View full report in Codecov by Sentry. |
jenshnielsen
reviewed
Apr 2, 2024
jenshnielsen
approved these changes
Apr 2, 2024
|
branch updated please approve 6 workflows |
jenshnielsen
reviewed
Apr 5, 2024
…er-fixes-improvements
auto-merge was automatically disabled
April 5, 2024 12:53
Head branch was pushed to by a user without write access
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.