Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence warning that may happen during teardown of simulated instruments. #5737

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

jenshnielsen
Copy link
Collaborator

No description provided.

@jenshnielsen jenshnielsen requested a review from a team as a code owner February 14, 2024 09:42
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8e02b1d) 67.55% compared to head (9bf8c27) 67.55%.

Files Patch % Lines
src/qcodes/instrument/visa.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5737      +/-   ##
==========================================
- Coverage   67.55%   67.55%   -0.01%     
==========================================
  Files         348      348              
  Lines       30246    30251       +5     
==========================================
+ Hits        20434    20437       +3     
- Misses       9812     9814       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newsfragment?

@jenshnielsen jenshnielsen added this pull request to the merge queue Feb 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 14, 2024
@jenshnielsen jenshnielsen added this pull request to the merge queue Feb 14, 2024
Merged via the queue into main with commit 0859390 Feb 14, 2024
16 of 18 checks passed
@jenshnielsen jenshnielsen deleted the silence_teardown_warning branch February 14, 2024 15:36
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants