Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore version popup for preview #1324

Closed
BernieWhite opened this issue Jan 13, 2024 · 0 comments · Fixed by #1325
Closed

Ignore version popup for preview #1324

BernieWhite opened this issue Jan 13, 2024 · 0 comments · Fixed by #1325
Assignees
@BernieWhite
Labels
bug Something isn't working
Milestone
v3.0.0

Comments

@BernieWhite
Copy link
Member

Description of the issue

Currently the notification the notification that you are using a preview version in unnecessary for the preview channel on v3.

V3 use VSCode's built-in handing for releases.

Expected behaviour

Only show the notification for the dev channel.
@BernieWhite BernieWhite added the bug Something isn't working label Jan 13, 2024
@BernieWhite BernieWhite self-assigned this Jan 13, 2024
@BernieWhite BernieWhite added this to the v3.0.0 milestone Jan 13, 2024
BernieWhite added a commit to BernieWhite/PSRule-vscode that referenced this issue Jan 13, 2024
@BernieWhite
Fix notification for preview microsoft#1324
f4f2e69
@BernieWhite BernieWhite mentioned this issue Jan 13, 2024
Merged
6 tasks
BernieWhite added a commit that referenced this issue Jan 13, 2024
@BernieWhite
Fix notification for preview #1324 (#1325)
ab6d4ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BernieWhite BernieWhite

Labels
bug Something isn't working
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging a pull request may close this issue.

Fix notification for preview #1324 BernieWhite/PSRule-vscode
1 participant
@BernieWhite