Added support for Auto Labeling to SCSensitivityLabel and some other minor fixes #5062
+1,030
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -108,11 +108,6 @@ | |||
| ModuleName = 'PnP.PowerShell' | |||
| RequiredVersion = '1.12.0' | |||
| }, | |||
| @{ | |||
| ModuleName = 'PSDesiredStateConfiguration' | |||
| RequiredVersion = '1.1' | |||
There was a problem hiding this comment.
This is because PSDesiredStateConfiguration isn't available in the PSGallery, but is installed by default with PSv5.1. When running the Update Dependencies cmdlet, this will never install because it is always present.....however when you have broken your environment the function cannot fix it because the module cannot be downloaded from the Gallery anyways.
There was a problem hiding this comment.
Bottom line, are we okay with removing this from the manifest? @ricmestre
There was a problem hiding this comment.
@NikCharlebois Yes, let's remove this please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR adds support for Auto Labeling settings to the SCSensitivityLabel resource, but also fixes some other minor issues I have encountered during testing.
This Pull Request (PR) fixes the following issues