Timing issue in Update-M365DSCAzureADApplication

[andikrueger]

I ran several test with the cmdLet and am seeing this issue:

Update-MgApplication : Key credential end date is invalid.
At C:\M365DSC\Microsoft365DSC\modules\M365DSCPermissions.psm1:1668 char:21
+ ...             $appCred = Update-MgApplication -ApplicationId $azureAdAp ...
+                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: ({ ApplicationId...phApplication }:<>f__AnonymousType0`2) [Update-MgApplication_Update  
   Expanded1], RestException`1
    + FullyQualifiedErrorId : KeyCredentialsInvalidEndDate,Microsoft.Graph.PowerShell.Cmdlets.UpdateMgApplication_UpdateExpanded1    

This looks like an timing issue within the code flow.

[NikCharlebois]

Sorry, what is the command you ran? What parameters?

[andikrueger]

The Update-m365dscAzureAdApplication. I have updated the title accordingly

[andikrueger]

Just to add some more context:

The function does fail 50 to 60% of the time. I think, there is to less time in between the creation of the certificate and the actual upload of it. Either we should add retry or increase the time in between. The retry option should try to upload the certificate several times. This would be the more resilient option.