Create webapp from arm template automatically #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
j-so
reviewed
Jun 2, 2020
j-so
suggested changes
Jun 18, 2020
|
I rebased, ported to the new CI/CD setup, and use AZ cli instead of ARM to get username/password. |
j-so
suggested changes
Sep 11, 2020
| @@ -40,3 +40,6 @@ steps: | |||
| # Set environment variable using the last line of logs that has the package location | |||
| IMAGE_LOCATION=$(tail -n 1 image_logs.txt) | |||
| echo "##vso[task.setvariable variable=IMAGE_LOCATION]$IMAGE_LOCATION" | |||
| echo $IMAGE_LOCATION > image_location.txt | |||
| IMAGE_TAGGED="$(sed 's/@sha256.*/:latest/g' image_location.txt)" | |||
| echo "##vso[task.setvariable variable=IMAGE_TAGGED]$IMAGE_TAGGED" | |||
There was a problem hiding this comment.
Why the need for this additional environment variable? Can we reuse the image location variable?
|
Have added additional instructions to the WebApp deployment part to detail required steps, until this is checked/automated. As mentioned, the image has to be created before the webapp can be created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to create the azure web app automatically from an ARM template (#275), so one does not have to do those manual steps. There are two points worth mentioning:
It seems like the azure web app must have an actual docker image available when it is created (with docker support), so instead of deploying the web app in the environment-setup pipeline, we have to set it up in the normal pipeline, after the docker image is pushed to the ACR. This should not be much of a problem, but there can be problems if you have policies in your tenant which automatically sets some properties (i.e. ftps only).
EDIT: This has now been changed to use AZ CLI instead. To get the password from the ACI I had to resort to quite an ugly hack. I tried to have the following in
webapp-env.json, but it just did not work (authentication error).If instead I entered the password directly it worked. And if I put that exact line in the "outputs" section in printed the password fine. It might have something to do with evaluation order of the function
listCredentials, IDK. So instead I had to create another ARM script which got the credentials, passed them as an output and then this output got used by the main ARM template as a parameter. 🤦This closes #275