move check to HandleStackTraceRequest and do it in parallel with a ti…

…meout
microsoft · Sep 17, 2020 · 529241d · 529241d
1 parent 8931a75
commit 529241d
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/src/OpenDebugAD7/AD7DebugSession.cs b/src/OpenDebugAD7/AD7DebugSession.cs
@@ -1258,7 +1258,7 @@ protected override void HandleStackTraceRequestAsync(IRequestResponder<StackTrac
                         levels = Math.Min((int)frameEnumInfo.TotalFrames - startFrame, levels);
                     }
 
-                    FRAMEINFO[] frameInfoArray = new FRAMEINFO[levels];
+                    var frameInfoArray = new FRAMEINFO[levels];
                     uint framesFetched = 0;
                     frameEnumInfo.FrameEnum.Next((uint)frameInfoArray.Length, frameInfoArray, ref framesFetched);
                     frameEnumInfo.CurrentPosition += framesFetched;
@@ -1288,6 +1288,19 @@ protected override void HandleStackTraceRequestAsync(IRequestResponder<StackTrac
                         });
                     }
 
+                    Parallel.ForEach(response.StackFrames, frame =>
+                    {
+                        if (frame.Source == null)
+                            return;
+                        var task = new Task<bool>(() => File.Exists(frame.Source.Path));
+                        task.Start();
+                        if (task.Wait(500) && !task.Result)
+                        {
+                            // mark the stack frame to be skipped by default
+                            frame.Source.PresentationHint = Source.PresentationHintValue.Deemphasize;
+                        }
+                    });
+
                     response.TotalFrames = (int)frameEnumInfo.TotalFrames;
                 }
             }

diff --git a/src/OpenDebugAD7/TextPositionTuple.cs b/src/OpenDebugAD7/TextPositionTuple.cs
@@ -41,11 +41,6 @@ public static TextPositionTuple GetTextPositionOfFrame(PathConverter converter,
                     Path = convertedFilePath,
                     Name = Path.GetFileName(convertedFilePath)
                 };
-                if (!File.Exists(convertedFilePath))
-                {
-                    // mark the stack frame to be skipped by default
-                    source.PresentationHint = Source.PresentationHintValue.Deemphasize;
-                }
 
                 int line = converter.ConvertDebuggerLineToClient((int)beginPosition[0].dwLine);
                 int column = unchecked((int)(beginPosition[0].dwColumn + 1));