Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[port 2.2]: Avoid two leading slashes in the request to create a new file (#22563) #22590

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

sonalideshpandemsft
Copy link
Contributor

@sonalideshpandemsft sonalideshpandemsft commented Sep 23, 2024

Cherry-pick: #22563

When using PFT+POP auth with ODSP, ODSP fails to validate the `p` field in the token when we have two leading slashes in the path. This is likely a bug in ODSP but it does result in cryptic 401 failure of the request.
@github-actions github-actions bot added area: driver Driver related issues area: odsp-driver base: release PRs targeted against a release branch labels Sep 23, 2024
Copy link
Contributor

Warning

WARNING: This PR is targeting a release branch!

All changes must first be merged into main and then backported to the target release branch.
Please include a link to the main PR in the description of this PR.

Changes to release branches require approval from the Patch Triage group before merging.
You should have already discussed this change with them so they know to expect it.

For more details, see our internal documentation for the patch policy and processes for
patch releases.

@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: +245 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 457.92 KB 457.96 KB +35 Bytes
azureClient.js 555.24 KB 555.29 KB +49 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 258.73 KB 258.75 KB +14 Bytes
fluidFramework.js 406.01 KB 406.02 KB +14 Bytes
loader.js 134.2 KB 134.22 KB +14 Bytes
map.js 42.25 KB 42.25 KB +7 Bytes
matrix.js 146.42 KB 146.42 KB +7 Bytes
odspClient.js 523.38 KB 523.43 KB +49 Bytes
odspDriver.js 97.66 KB 97.68 KB +21 Bytes
odspPrefetchSnapshot.js 42.72 KB 42.73 KB +14 Bytes
sharedString.js 163.12 KB 163.13 KB +7 Bytes
sharedTree.js 396.52 KB 396.53 KB +7 Bytes
Total Size 3.3 MB 3.3 MB +245 Bytes

Baseline commit: 59cbe15

Generated by 🚫 dangerJS against 6d9ad73

@frankmueller-msft
Copy link

Approved

@frankmueller-msft frankmueller-msft merged commit 0afcb96 into release/client/2.2 Sep 23, 2024
31 of 32 checks passed
@frankmueller-msft frankmueller-msft deleted the patch-slashes-change-2.2 branch September 23, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: driver Driver related issues area: odsp-driver base: release PRs targeted against a release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants