Handle Location redirection for getSharingInformation call #22551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: driver
⯅ @fluid-example/bundle-size-tests: +245 Bytes
Baseline commit: fc0a441 |
jatgarg
added a commit
to jatgarg/FluidFramework-1
that referenced
this pull request
Sep 20, 2024
…#22551) ## Description [AB#15188](https://dev.azure.com/fluidframework/internal/_workitems/edit/15188) Handle location redirection when calling getSharingInformation in ODSP Driver. Since this call does not include the v2.0 which calls the API without the drive and item ID, these calls fail if the tenant has been renamed. Sometimes this creates issues when creating a new page, since the user could not get the sharing link to the new page. GetFileItem call also returns the new siteUrl to which the file has been moved. Use that to detect the new domain and then change the resolved url accordingly. Co-authored-by: Jatin Garg <jatingarg@Jatins-MacBook-Pro-2.local>
frankmueller-msft
pushed a commit
that referenced
this pull request
Sep 24, 2024
…aringInformation call (#22551) (#22577) ## Description [AB#15188](https://dev.azure.com/fluidframework/internal/_workitems/edit/15188) Handle location redirection when calling getSharingInformation in ODSP Driver. Since this call does not include the v2.0 which calls the API without the drive and item ID, these calls fail if the tenant has been renamed. Sometimes this creates issues when creating a new page, since the user could not get the sharing link to the new page. GetFileItem call also returns the new siteUrl to which the file has been moved. Use that to detect the new domain and then change the resolved url accordingly. --------- Co-authored-by: Jatin Garg <jatingarg@Jatins-MacBook-Pro-2.local>
jatgarg
added a commit
to jatgarg/FluidFramework-1
that referenced
this pull request
Sep 24, 2024
…#22551) ## Description [AB#15188](https://dev.azure.com/fluidframework/internal/_workitems/edit/15188) Handle location redirection when calling getSharingInformation in ODSP Driver. Since this call does not include the v2.0 which calls the API without the drive and item ID, these calls fail if the tenant has been renamed. Sometimes this creates issues when creating a new page, since the user could not get the sharing link to the new page. GetFileItem call also returns the new siteUrl to which the file has been moved. Use that to detect the new domain and then change the resolved url accordingly. Co-authored-by: Jatin Garg <jatingarg@Jatins-MacBook-Pro-2.local>
jatgarg
added a commit
to jatgarg/FluidFramework-1
that referenced
this pull request
Sep 24, 2024
…#22551) ## Description [AB#15188](https://dev.azure.com/fluidframework/internal/_workitems/edit/15188) Handle location redirection when calling getSharingInformation in ODSP Driver. Since this call does not include the v2.0 which calls the API without the drive and item ID, these calls fail if the tenant has been renamed. Sometimes this creates issues when creating a new page, since the user could not get the sharing link to the new page. GetFileItem call also returns the new siteUrl to which the file has been moved. Use that to detect the new domain and then change the resolved url accordingly. Co-authored-by: Jatin Garg <jatingarg@Jatins-MacBook-Pro-2.local>
jatgarg
added a commit
to jatgarg/FluidFramework-1
that referenced
this pull request
Sep 24, 2024
…#22551) ## Description [AB#15188](https://dev.azure.com/fluidframework/internal/_workitems/edit/15188) Handle location redirection when calling getSharingInformation in ODSP Driver. Since this call does not include the v2.0 which calls the API without the drive and item ID, these calls fail if the tenant has been renamed. Sometimes this creates issues when creating a new page, since the user could not get the sharing link to the new page. GetFileItem call also returns the new siteUrl to which the file has been moved. Use that to detect the new domain and then change the resolved url accordingly. Co-authored-by: Jatin Garg <jatingarg@Jatins-MacBook-Pro-2.local>
jatgarg
added a commit
to jatgarg/FluidFramework-1
that referenced
this pull request
Sep 24, 2024
…#22551) ## Description [AB#15188](https://dev.azure.com/fluidframework/internal/_workitems/edit/15188) Handle location redirection when calling getSharingInformation in ODSP Driver. Since this call does not include the v2.0 which calls the API without the drive and item ID, these calls fail if the tenant has been renamed. Sometimes this creates issues when creating a new page, since the user could not get the sharing link to the new page. GetFileItem call also returns the new siteUrl to which the file has been moved. Use that to detect the new domain and then change the resolved url accordingly. Co-authored-by: Jatin Garg <jatingarg@Jatins-MacBook-Pro-2.local>
frankmueller-msft
added a commit
that referenced
this pull request
Sep 25, 2024
…ngInformation call (#22551) (#22621) ## Description [AB#15188](https://dev.azure.com/fluidframework/internal/_workitems/edit/15188) Handle location redirection when calling getSharingInformation in ODSP Driver. Since this call does not include the v2.0 which calls the API without the drive and item ID, these calls fail if the tenant has been renamed. Sometimes this creates issues when creating a new page, since the user could not get the sharing link to the new page. GetFileItem call also returns the new siteUrl to which the file has been moved. Use that to detect the new domain and then change the resolved url accordingly. Co-authored-by: Jatin Garg <jatingarg@Jatins-MacBook-Pro-2.local> Co-authored-by: Frank Mueller <103605701+frankmueller-microsoft@users.noreply.github.com>
jatgarg
added a commit
that referenced
this pull request
Sep 25, 2024
…ngInformation call (#22551) (#22619) ## Description Main PR Link: #22551 [AB#15188](https://dev.azure.com/fluidframework/internal/_workitems/edit/15188) Handle location redirection when calling getSharingInformation in ODSP Driver. Since this call does not include the v2.0 which calls the API without the drive and item ID, these calls fail if the tenant has been renamed. Sometimes this creates issues when creating a new page, since the user could not get the sharing link to the new page. GetFileItem call also returns the new siteUrl to which the file has been moved. Use that to detect the new domain and then change the resolved url accordingly. Co-authored-by: Jatin Garg <jatingarg@Jatins-MacBook-Pro-2.local>
frankmueller-msft
added a commit
that referenced
this pull request
Sep 25, 2024
…ngInformation call (#22551) (#22622) ## Description [AB#15188](https://dev.azure.com/fluidframework/internal/_workitems/edit/15188) Handle location redirection when calling getSharingInformation in ODSP Driver. Since this call does not include the v2.0 which calls the API without the drive and item ID, these calls fail if the tenant has been renamed. Sometimes this creates issues when creating a new page, since the user could not get the sharing link to the new page. GetFileItem call also returns the new siteUrl to which the file has been moved. Use that to detect the new domain and then change the resolved url accordingly. --------- Co-authored-by: Jatin Garg <jatingarg@Jatins-MacBook-Pro-2.local> Co-authored-by: Frank Mueller <103605701+frankmueller-microsoft@users.noreply.github.com>
frankmueller-msft
pushed a commit
that referenced
this pull request
Sep 25, 2024
…ngInformation call (#22551) (#22620) ## Description [AB#15188](https://dev.azure.com/fluidframework/internal/_workitems/edit/15188) Handle location redirection when calling getSharingInformation in ODSP Driver. Since this call does not include the v2.0 which calls the API without the drive and item ID, these calls fail if the tenant has been renamed. Sometimes this creates issues when creating a new page, since the user could not get the sharing link to the new page. GetFileItem call also returns the new siteUrl to which the file has been moved. Use that to detect the new domain and then change the resolved url accordingly. Co-authored-by: Jatin Garg <jatingarg@Jatins-MacBook-Pro-2.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AB#15188
Handle location redirection when calling getSharingInformation in ODSP Driver. Since this call does not include the v2.0 which calls the API without the drive and item ID, these calls fail if the tenant has been renamed. Sometimes this creates issues when creating a new page, since the user could not get the sharing link to the new page.
GetFileItem call also returns the new siteUrl to which the file has been moved. Use that to detect the new domain and then change the resolved url accordingly.