Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 2.3 release notes #22542

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Add 2.3 release notes #22542

merged 1 commit into from
Sep 17, 2024

Conversation

CraigMacomber
Copy link
Contributor

Description

Done by checking cherrypicking #22541

Reviewer Guidance

The review process is outlined on this wiki page.

@CraigMacomber
Add 2.3 release notes (#22541)
c5cfc2e 
Add 2.3 release notes.
Done by checking out 47febab (before
changesets were generated), modifying `.changeset/moody-rats-cover.md`
to be a "minor" change and running:

pnpm flub generate releaseNotes -g client -t minor --outFile
RELEASE_NOTES/2.3.0.md
@CraigMacomber CraigMacomber requested a review from a team as a code owner September 17, 2024 00:18
@github-actions github-actions bot added the base: release PRs targeted against a release branch label Sep 17, 2024
@CraigMacomber CraigMacomber changed the base branch from release/client_workaround/2.3 to release/client/2.3 September 17, 2024 00:50
@github-actions GitHub Actions
Copy link
Contributor

Warning

WARNING: This PR is targeting a release branch!

All changes must first be merged into main and then backported to the target release branch.
Please include a link to the main PR in the description of this PR.

Changes to release branches require approval from the Patch Triage group before merging.
You should have already discussed this change with them so they know to expect it.

For more details, see our internal documentation for the patch policy and processes for
patch releases.

@tylerbutler
Copy link
Member

@CraigMacomber My approval caused the check to pass because I am on the triage team at the moment. You should be able to check the "Merge without waiting for requirements to be met (by[ass branch protections) to merge these in the future if the ONLY check not passing is "Check PR approval". (maybe we should re-phrase that check)

@CraigMacomber CraigMacomber enabled auto-merge (squash) September 17, 2024 01:07
@CraigMacomber
Copy link
Contributor Author

@CraigMacomber My approval caused the check to pass because I am on the triage team at the moment. You should be able to check the "Merge without waiting for requirements to be met (by[ass branch protections) to merge these in the future if the ONLY check not passing is "Check PR approval". (maybe we should re-phrase that check)

I can force enable auto merge, but I can't merge.

"Merging is blocked
The base branch does not allow updates. Learn more about protected branches."

@CraigMacomber CraigMacomber enabled auto-merge (squash) September 17, 2024 01:09
@CraigMacomber CraigMacomber merged commit c5359ba into release/client/2.3 Sep 17, 2024
32 checks passed
@CraigMacomber CraigMacomber deleted the releaseNotes2 branch September 17, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerbutler tylerbutler tylerbutler approved these changes

Assignees
No one assigned
Labels
base: release PRs targeted against a release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CraigMacomber @tylerbutler