Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[port 2.0]: Fix upload release report step #22167

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

sonalideshpandemsft
Copy link
Contributor

@sonalideshpandemsft sonalideshpandemsft commented Aug 9, 2024

Cherry-pick:

#21887
#21969
#22125

Test Run

The release reports are currently uploaded at the very beginning of the
CI run, which is problematic because build or test failures could occur,
causing an incorrect release report to be published to the azure blob.

This update relocates the upload step under the publish section,
ensuring that reports are only uploaded after a successful build and
test run.

[Test
Run](https://dev.azure.com/fluidframework/internal/_build/results?buildId=280522&view=logs&j=c719ff29-64ed-5818-044d-14407c6a65d1)

[AB#8886](https://dev.azure.com/fluidframework/internal/_workitems/edit/8886)
The server pipeline started to fail due to this commit:
#21887.

The follow-up should fix the server pipeline.

[Test
Run](https://dev.azure.com/fluidframework/internal/_build/results?buildId=281718&view=results)
With the merge of
#22030, test branches
now pass the client pipeline successfully. As a result, release reports
can also be generated for test versions published to the test feed.

[Test
Run](https://dev.azure.com/fluidframework/internal/_build/results?buildId=285541&view=results)

[AB#8042](https://dev.azure.com/fluidframework/internal/_workitems/edit/8042)
Copy link

changeset-bot bot commented Aug 9, 2024

⚠️ No Changeset found

Latest commit: 2d29185

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sonalideshpandemsft sonalideshpandemsft marked this pull request as draft August 9, 2024 17:44
@sonalideshpandemsft sonalideshpandemsft changed the title Test/fix release reports 2.0: Move upload release report step Aug 9, 2024
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Aug 9, 2024

Could not find a usable baseline build with search starting at CI f0af214

Generated by 🚫 dangerJS against 2d29185

@sonalideshpandemsft sonalideshpandemsft changed the title 2.0: Move upload release report step [port 2.0]: Fix upload release report step Aug 9, 2024
@sonalideshpandemsft sonalideshpandemsft marked this pull request as ready for review August 12, 2024 17:30
@frankmueller-msft frankmueller-msft merged commit 8b98697 into release/client/2.0 Aug 12, 2024
67 checks passed
@frankmueller-msft frankmueller-msft deleted the test/fix-release-reports branch August 12, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants