Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC.5.0 Port - Put Memory Blob Storage Under a Flag (#21612) #21618

Conversation

anthony-murphy
Copy link
Contributor

We recently made changes to how detached blob storage works, and enabled a default in-memory blob storage such that blobs would be supported by default in detached containers.

However, when blobs are in a detached container, it changes the container attachment flow, specifically, an empty file is created, the blobs are uploaded, and then the summary is uploaded. Due to this differing flow some drivers, like odsp, create files with a .tmp extension appended to the file name, this is meant to signify that that file could be incomplete. For example, the summary could fail to upload after blobs have been uploaded, and this will not be a valid fluid file. it is expected that the application will rename the file after attachment completes if the .tmp extension is not desired. If an application does not expect the .tmp extension this can create issues, so for now, we will put this support under a flag, that must be explicitly enabled "Fluid.Container.MemoryBlobStorageEnabled" = true so that apps must opt into this behavior.

related to #21144

We recently made changes to how detached blob storage works, and enabled
a default in-memory blob storage such that blobs would be supported by
default in detached containers.

However, when blobs are in a detached container, it changes the
container attachment flow, specifically, an empty file is created, the
blobs are uploaded, and then the summary is uploaded. Due to this
differing flow some drivers, like odsp, create files with a `.tmp`
extension appended to the file name, this is meant to signify that that
file could be incomplete. For example, the summary could fail to upload
after blobs have been uploaded, and this will not be a valid fluid file.
it is expected that the application will rename the file after
attachment completes if the `.tmp` extension is not desired. If an
application does not expect the `.tmp` extension this can create issues,
so for now, we will put this support under a flag, that must be
explicitly enabled `"Fluid.Container.MemoryBlobStorageEnabled" = true`
so that apps must opt into this behavior.

related to microsoft#21144

Co-authored-by: Tony Murphy <anthonm@microsoft.com>
@anthony-murphy anthony-murphy enabled auto-merge (squash) June 25, 2024 21:27
@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: +501 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 451.96 KB 451.96 KB No change
azureClient.js 550.38 KB 550.55 KB +167 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 255.82 KB 255.82 KB No change
fluidFramework.js 374.96 KB 374.96 KB No change
loader.js 133.27 KB 133.43 KB +167 Bytes
map.js 41.12 KB 41.12 KB No change
matrix.js 143.41 KB 143.41 KB No change
odspClient.js 518.46 KB 518.62 KB +167 Bytes
odspDriver.js 97.26 KB 97.26 KB No change
odspPrefetchSnapshot.js 42.24 KB 42.24 KB No change
sharedString.js 159.92 KB 159.92 KB No change
sharedTree.js 374.95 KB 374.95 KB No change
Total Size 3.22 MB 3.22 MB +501 Bytes

Baseline commit: 786b7d0

Generated by 🚫 dangerJS against a987a90

@anthony-murphy anthony-murphy merged commit 4668da5 into microsoft:release/client/2.0.0-rc.5.0 Jun 25, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants