Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Publish patch GitHub releases automatically #21309

Merged
merged 1 commit into from
Jun 5, 2024
Merged

ci: Publish patch GitHub releases automatically #21309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions .github/workflows/push-tag-create-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ jobs:
echo "RELEASE_JSON=$(cat release-metadata.json)" >> $GITHUB_ENV
- name: Set releaseType output variable
run: |
echo "releaseType=${{ fromJson(env.RELEASE_JSON).packageOrReleaseGroup }}" >> "$GITHUB_OUTPUT"
echo "releaseType=${{ fromJson(env.RELEASE_JSON).packageOrReleaseGroup }}" >> "$GITHUB_OUTPUT"

# Generate release reports
- name: Check out tag
Expand Down Expand Up @@ -103,7 +103,7 @@ jobs:
run: |
echo "This is a **${{ fromJson(env.RELEASE_JSON).releaseType }}** release." > auto-changelog.md

# Only creates GH releases for client and build-tools releases.
# Only creates GH releases for client, server, and build-tools releases.
- name: Create GH release
if: fromJson(env.RELEASE_JSON).packageOrReleaseGroup == 'client' || fromJson(env.RELEASE_JSON).packageOrReleaseGroup == 'build-tools' || fromJson(env.RELEASE_JSON).packageOrReleaseGroup == 'server'
uses: ncipollo/release-action@eb05307dcee34deaad054e98128088a30d7980dc # ratchet:ncipollo/release-action@main
Expand All @@ -114,10 +114,15 @@ jobs:
# Will skip if a published (non-draft) release already exists.
skipIfReleaseExists: true

# Leave the release as a draft so that the release engineer can verify it before it's public. Once we are
# more confident in the automation, we may update this workflow to publish the release as well.
draft: true
omitDraftDuringUpdate: true # don't change the draft state when updating
# If the release is NOT a patch, leave it as a draft. Only patch releases are auto-published because their
# auto-generated release notes are sufficient for those releases. Minor and major releases currently require
# some curation of the release notes.
draft: ${{ fromJson(env.RELEASE_JSON).releaseType != 'patch' }}

# Don't change the draft state when updating an existing release. This setting is not really necessary for us
# in most cases because we don't pre-create releases, so this workflow always creates a new GH release. It's
# included mostly for safety reasons, to ensure that existing drafts aren't published accidentally.
omitDraftDuringUpdate: true

name: ${{ fromJson(env.RELEASE_JSON).title }}
omitNameDuringUpdate: false # always overwrite the name
Expand Down
Loading