Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree(fix): Remove accidentally exposed identifier API #20720

Conversation

noencke
Copy link
Contributor

@noencke noencke commented Apr 17, 2024

Description

This is a patch of PR 20718

This bug fix removes an accidentally-exposed API in tree. The API in question, identifiers, is exposed in schema creation but is not usable in the current state and thus this change will not have any customer impact. The API will be re-added in the future when it functions.

@noencke noencke requested a review from taylorsw04 April 17, 2024 21:52
@noencke noencke requested a review from a team as a code owner April 17, 2024 21:52
@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: -594 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 452.28 KB 452.28 KB No change
azureClient.js 545.36 KB 545.36 KB No change
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 255.17 KB 255.17 KB No change
fluidFramework.js 339.68 KB 339.39 KB -297 Bytes
loader.js 129.89 KB 129.89 KB No change
map.js 41.35 KB 41.35 KB No change
matrix.js 143.62 KB 143.62 KB No change
odspClient.js 513.35 KB 513.35 KB No change
odspDriver.js 97.06 KB 97.06 KB No change
odspPrefetchSnapshot.js 41.93 KB 41.93 KB No change
sharedString.js 161.39 KB 161.39 KB No change
sharedTree.js 339.68 KB 339.39 KB -297 Bytes
Total Size 3.14 MB 3.14 MB -594 Bytes

Baseline commit: b2bbc67

Generated by 🚫 dangerJS against 9b18de1

@tylerbutler
Copy link
Member

Please add more details to the PR description, and perhaps a more descriptive title, before merge. Since this will go out as a patch the info here will be what winds up in the release notes, so make it as customer-ready as possible.

@taylorsw04 taylorsw04 changed the title Remove Identifier API tree: Remove accidentally exposed identifier API Apr 18, 2024
@taylorsw04 taylorsw04 changed the title tree: Remove accidentally exposed identifier API tree(fix): Remove accidentally exposed identifier API Apr 18, 2024
@taylorsw04 taylorsw04 merged commit 0920904 into microsoft:release/client/2.0.0-rc.3.0 Apr 18, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants